search

cbrnix / Newaita

Linux icon theme
390 stars 16 forks source link

The 16px and 22px "places" icons do not have "dark" variants. #149

Closed PJ-Singh-001 closed 4 years ago

PJ-Singh-001 commented 4 years ago

SUMMARY

The 16px and 22px places icons use the same images for both the "light" and "dark" variants.

(This is only an issue for the smaller 16px and 22px size icons, because they are monochrome, whereas the larger icons using color images do not exhibit this issue).

As an example of how it should be, see the 16px and 22px actions icons which have both a "light" variant and a "dark" variant.

DETAILS

PROBLEM

(1) /usr/share/icons/Newaita-dark/.places-*/16/ ...uses the same Light variant icons as.... /usr/share/icons/Newaita/.places-*/16/

(2) /usr/share/icons/Newaita-dark/.places-*/22/ ...uses the same Light variant icons as.... /usr/share/icons/Newaita/.places-*/22/

SPECIFIC EXAMPLE

This applies to all the 16px and 22 px places icons, but here is one specific example...

EXAMPLE OF HOW IT SHOULD WORK

In contrast, the Newaita actions icons correctly have both light and dark variants...

(3) /usr/share/icons/Newaita-dark/.actions-*/16/ ...uses DIFFERENT icons from... /usr/share/icons/Newaita/.actions-*/16/

(4) /usr/share/icons/Newaita-dark/.actions-*/22/ ...uses DIFFERENT icons from... /usr/share/icons/Newaita/.actions-*/22/

SCREENSHOTS OF THE ISSUE

Newaita_with_Light_Theme

Newaita-dark_with_Dark_Theme png

RECREATE THE ISSUE

Save the following file as places_icons_example.glade.

Open this file in the Glade application. Then highlight "GtkWindow" in the left pane, and click the "Preview snapshot" icon at the bottom of the left pane.

  1. Change your Gtk theme to a light theme (such as Yaru or Adwaita). Change your icon theme to Newaita. Everything looks OK.

  2. Change your Gtk theme to a dark theme (such as Yaru-dark). Notice the icons are barely visible, since they are still using the (light) Newaita icon theme. This is expected.

  3. Next, change your Icon theme to Newaita-dark. Notice the action icon (gtk-open) is correctly showing a dark variant and is visible against the dark background. Notice the places icon (gtk-directory) is STILL showing the LIGHT variant ad is NOT visible against the dark background. The expected behavior is for gtk-directory to be rendered using a different appropriate image for folder.svg.

<?xml version="1.0" encoding="UTF-8"?>
<!-- Generated with glade 3.22.1 -->
<interface>
  <requires lib="gtk+" version="3.20"/>
  <object class="GtkWindow">
    <property name="can_focus">False</property>
    <property name="border_width">18</property>
    <child>
      <placeholder/>
    </child>
    <child>
      <object class="GtkGrid">
        <property name="width_request">400</property>
        <property name="visible">True</property>
        <property name="can_focus">False</property>
        <property name="row_spacing">16</property>
        <property name="column_spacing">16</property>
        <property name="row_homogeneous">True</property>
        <child>
          <object class="GtkImage">
            <property name="visible">True</property>
            <property name="can_focus">False</property>
            <property name="stock">gtk-open</property>
          </object>
          <packing>
            <property name="left_attach">0</property>
            <property name="top_attach">0</property>
          </packing>
        </child>
        <child>
          <object class="GtkLabel">
            <property name="visible">True</property>
            <property name="can_focus">False</property>
            <property name="hexpand">True</property>
            <property name="label" translatable="yes">This action icon (gtk-open) has both a light and dark variant, so it can be changed with the theme. (Try changing your Icon theme, alternating between Newaita and Newaita-dark, and see how the icon changes).</property>
            <property name="wrap">True</property>
            <property name="max_width_chars">0</property>
            <property name="xalign">0</property>
          </object>
          <packing>
            <property name="left_attach">1</property>
            <property name="top_attach">0</property>
          </packing>
        </child>
        <child>
          <object class="GtkImage">
            <property name="visible">True</property>
            <property name="can_focus">False</property>
            <property name="stock">gtk-directory</property>
          </object>
          <packing>
            <property name="left_attach">0</property>
            <property name="top_attach">1</property>
          </packing>
        </child>
        <child>
          <object class="GtkLabel">
            <property name="visible">True</property>
            <property name="can_focus">False</property>
            <property name="hexpand">True</property>
            <property name="label" translatable="yes">This places icon (gtk-directory) only has a light variant. When the theme is changed, this icon stays the same. This is a problem when a dark GTK theme is selected along with the Newaita-dark icon theme. (Try changing your Icon them, alternating between Newaita and Newaita-dark, and see how the icon stays the same).</property>
            <property name="wrap">True</property>
            <property name="max_width_chars">0</property>
            <property name="xalign">0</property>
          </object>
          <packing>
            <property name="left_attach">1</property>
            <property name="top_attach">1</property>
          </packing>
        </child>
      </object>
    </child>
  </object>
</interface>
cbrnix commented 4 years ago

Let's start with which version you are using. In git, dark and light themes use the corresponding monochrome icons. Moreover, they have a parameter:

<defs>
<style id = "current-color-scheme" type = "text / css">
.ColorScheme-Text {color: #eeeeee; } .ColorScheme-Highlight {color: # 424242; }
</style>
</defs>

Allowing CSS level to change color independently, depending on the background

cbrnix commented 4 years ago

https://github.com/cbrnix/Newaita/blob/master/Newaita-dark/.places-aqua/16/folder.svg

https://github.com/cbrnix/Newaita/blob/master/Newaita/.places-aqua/16/folder.svg

Here is an example of monochrome icons in dark and light themes

cbrnix commented 4 years ago

After changing the theme from dark to light, you tried gtk-update-icon-cache?

cbrnix commented 4 years ago

If you use the AUR version, then I do not do it. It may be outdated at this time.

PJ-Singh-001 commented 4 years ago

Thanks for looking @ this. I'll reinstall and check.

PJ-Singh-001 commented 4 years ago

I downloaded and tested the latest release, and the issue I had reported is no longer present.

Thanks for your time once again. This is truly a beautiful and comprehensive icon theme. You responsiveness and talent are unmatched!!

Screenshot from 2020-05-08 10-30-13