cbrnix / Newaita

Linux icon theme
387 stars 16 forks source link

Crow Translate tray icon #155

Closed Shatur closed 4 years ago

Shatur commented 4 years ago

You already have tray icons for light and dark variants (crow-translate-tray-dark.svg and crow-translate-tray-light.svg), but missing crow-translate-tray.svg that contains light or dark depends on theme variant. I also suggest to move such icon to panel as in Papirus theme.

I laso noticed that dark and light variants looks the same in theme variant (all dark or all light). They thought to be different.

cbrnix commented 4 years ago

Added

Shatur commented 4 years ago

Thanks! But crow-translate-dark.svg and crow-translate-light.svg still looks the same (both are light in light theme variant and both are dark in dark variant). Could you make this icons independent of theme? I mean to always use light variant for crow-translate-dark.svg and always use dark for crow-translate-light.svg?

Here is how the icons look originally.

cbrnix commented 4 years ago

In gtk3, they must independently change the color. Later, if you want, I will do

Shatur commented 4 years ago

In this app only crow-translate-tray.svg changes color depends on theme. crow-translate-dark.svg and crow-translated-dark.svg needed if user want to set icon style independently. The same approach you can see in qBittorrent.

cbrnix commented 4 years ago

check, pls

Shatur commented 4 years ago

Thanks you a lot, now as expected :)