cbrnix / Newaita

Linux icon theme
389 stars 16 forks source link

Missing `preferences-ubuntu-panel-symbolic.svg` icon for Appearance Settings in Ubuntu 21.04 #184

Open PJ-Singh-001 opened 3 years ago

PJ-Singh-001 commented 3 years ago

In the latest version of Newaita (1.09.20a), the "Light" version of the "Appearance" icon used in the left pane of Ubuntu 21.04's System Settings has an issue.

Only the central portion (the "eye") of the icon is visible. The rest of the icon (the "display monitor" portion) is not visible.

This affects the light version of Newaita...

Screenshot from 2021-04-27 20-54-21

The dark version of this icon looks OK...

Screenshot from 2021-04-27 20-55-01

PJ-Singh-001 commented 3 years ago

I found which icon is used. It is named preferences-ubuntu-panel-symbolic.svg.

ISSUE

Icon themes that support light and dark window themes have their own version of the preferences-ubuntu-panel-symbolic.svg icon.

However, Newaita inherits from breeze, gnome, and hicolor themes, so there is no "working" version of the preferences-ubuntu-panel-symbolic.svg icon that Newaita can fall back to.

The hicolor theme has the following icon:

preferences-ubuntu-panel-symbolic (hicolor/scalable/apps/preferences-ubuntu-panel-symbolic.svg)

Unfortunately, the hicolor version of this icon does not render completely when the a light colored window theme is selected. In a light colored window theme, you can not see the display monitor, just the eye portion of the icon.

This is not an issue with the hicolor icon theme, because it is not designed to adapt to light and dark window themes.

WORKING EXAMPLE

For example, the Yaru theme has the following icon:

preferences-ubuntu-panel-symbolic_Yaru (Yaru/scalable/categories/preferences-ubuntu-panel-symbolic.svg)

This icon does render completely for both light and dark colored window themes. You can see the display monitor and the eye portions of the icon.

SOLUTION

Newaita needs its own icon named preferences-ubuntu-panel-symbolic.svg. This icon should be placed in Newaita/categories/scalable/preferences-ubuntu-panel-symbolic.svg (I think).

PJ-Singh-001 commented 3 years ago

As a work-around, I created a link named preferences-ubuntu-panel-symbolic.svg pointing to view-presentation.svg.

sudo ln -sr /usr/share/icons/Newaita/actions/16/view-presentation.svg /usr/share/icons/Newaita/devices/symbolic/preferences-ubuntu-panel-symbolic.svg

image