search

cbrnix / Newaita

Linux icon theme
386 stars 16 forks source link

Missing icons: OCaml (.ml) and KeePassX (.kbdx) #79

Closed macthecadillac closed 5 years ago

macthecadillac commented 5 years ago

I noticed that icons for OCaml source files (.ml) and KeePassX database files (.kbdx) are missing. Could you add those icons?

Great work on creating this icon set by the way. I really enjoy it.

cbrnix commented 5 years ago

Unfortunately, I do not use them. Can you drop two such files so that I can see the mimetypes?

macthecadillac commented 5 years ago

That is understandable. There you go: MIME_Samples.tar.gz

I tarred them since GitHub doesn't support dropping these files directly.

cbrnix commented 5 years ago

Wait, these files are defined as text and empty. Mimetypes for them should be drawn. изображение

macthecadillac commented 5 years ago

.ml files are source code files of OCaml so they are really just text files. I guess whichever way you made it work for other kinds of source files (such as Python or Rust) should work here.

As for .kdbx files, I don't know how to help with that since the file I dropped earlier was directly generated by KeePassX. Dolphin seems to able to recognize them on my machine though.

dolphin

cbrnix commented 5 years ago

Done. Check pls

macthecadillac commented 5 years ago

The icon for OCaml is kinda cute :). The KeePassX database icons are still missing but I guess that's about what we can do now.

cbrnix commented 5 years ago

The KeePassX should be reflected. Perhaps just cache problems

cbrnix commented 5 years ago

Oh... Added application-x-keepassx now

macthecadillac commented 5 years ago

Also symlink it to application-x-keepassxc so that icons on systems with KeePassXC (a KeePassX fork) will display properly (that was the reason your fix didn't work on my system).

cbrnix commented 5 years ago

added