search

cdk / nodes4knime

KNIMES nodes using the CDK 1.5 library.
3 stars 5 forks source link

review current code base #2

Open egonw opened 6 years ago

egonw commented 6 years ago

@sithmein, can you have a look at this too?

Checks needed:

sithmein commented 6 years ago

Can you move the projects in org.openscience to top-level? This is the standard setup for all other Git repositories and the build system expects the projects there. I will change the build job in Jenkins to use the new Git repo and then we see whether it works or not.

egonw commented 6 years ago

OK, yes, I can do that.

egonw commented 6 years ago

@sithmein, done!

sithmein commented 6 years ago

The Jenkins job works fine, however there is a testcase failure (although not new as far as I can tell):

https://community.knime.org/jenkins/job/org.openscience.cdk.knime.update-trunk/lastCompletedBuild/testReport/

(access with your KNIME forum account, in case it doesn't work, tell me your account name).

egonw commented 6 years ago

@sithmein, turned out I did not have a forum account yet, but I'm now in the pending list...

egonw commented 6 years ago

@sithmein, does the Jenkins build service create an update site from which people can install the development version? At least, allowing me to test the last step (4)?

sithmein commented 6 years ago

All stable builds will be deployed to the corresponding public update sites (see https://www.knime.com/community for a full list). Unstable builds can only be downloaded from the Jenkins job.

egonw commented 6 years ago

OK, I guess Jenkins automatically sets versions numbers of the feature, correct? I also do not have to set the KNIME version it is for, right (with updates like this)?

sithmein commented 6 years ago

The .qualifier is filled automatically with the last change date in the SCM and is propagated to the featue. The first three parts of the version number you have to set manually and you are free to choose them yourself (following the rules for semantic versioning).