search

cdk / nodes4knime

KNIMES nodes using the CDK 1.5 library.
3 stars 5 forks source link

upgrade to CDK 2 #6

Open egonw opened 6 years ago

egonw commented 6 years ago

This turns out to be a bit harder than expected, as it simultaneously needs updating of JChemPaint and AMBIT ...

johnmay commented 6 years ago

not an "issue"... this is a ToDo

johnmay commented 6 years ago

Have unsubscribed from all nodes3knime related updates now :-). So feel free to use this is a todo list

rajarshi commented 5 years ago

Are there any updates on this?

egonw commented 5 years ago

No :(

egonw commented 5 years ago

I have recently looked into updating JChemPaint to CDK 2.1 and 2.0, but there are regressions. See https://github.com/JChemPaint/jchempaint/issues/191

webbres commented 2 years ago

Is JChemPaint the blocker and if so is this still the case?

Could we rebrand the existing nodes legacy nodes and create a new plugin based on CDK 2.x?

egonw commented 2 years ago

@webbres, that's exactly what Daria and I were discussing yesterday.

webbres commented 2 years ago

👍 happy to contribute to that effort if it's done

egonw commented 2 years ago

I've forked a repo for this: https://github.com/cdk/nodes4knime-cdk2

But the wifi here is too slow to set up the KNIME SDK

johnmay commented 2 years ago

Why did you fork it Egon? The API should be compatible enough that it didn't need a fork. Any changes are likely unspecified invariants being missed by the callee.

webbres commented 2 years ago

I think the main issue is JChemPaint and Ambit don't work with CDK 2, so upgrading loses that functionality which breaks backwards compatibility with existing workflows.

You can't deprecate the nodes as they don't work anymore.

egonw commented 2 years ago

Why did you fork it Egon? The API should be compatible enough that it didn't need a fork. Any changes are likely unspecified invariants being missed by the callee.

Think of it as the migration path from Python2 to Python3: there were so many dependencies, many tools could not easily migrate to Python3. Similarly, there is functonality in the CDK-1.5-based KNIME nodes that are not easily migrated.

The idea of the fork is to have both world in parallel, allowing people to use CDK-2.x-based KNIME nodes whenever possible, but at the same time being able to install the CDK-1.5-based KNIME nodes when needed.