search

cdk / nodes4knime

KNIMES nodes using the CDK 1.5 library.
2 stars 5 forks source link

Plugin not compatible with KNIME 4.0 #8

Closed webbres closed 2 years ago

webbres commented 5 years ago

The plugin specifies the max version is 4.0 and needs to be changed to 5.0.

I can submit a pull request for this if you'd like?

webbres commented 5 years ago

I'm not sure how to link a pull request in github with an issue.

This PR should fix this issue and allow KNIME to build for 4.0: https://github.com/cdk/nodes4knime/pull/9

Should another release branch be made for 4.0? It seems KNIME 3.5, 3.6 and 3.7 are all using the 3.5 branch?

egonw commented 5 years ago

Creating a 4.0 branch makes sense to me.

webbres commented 5 years ago

Thank you for merging the PR 👍

I can update the KNIME 4 jenkins build if you could make the branch? The build currently works but it doesn't look like it can actually be installed into the KNIME 4 application.

egonw commented 5 years ago

https://github.com/cdk/nodes4knime/tree/dev/knime4

webbres commented 5 years ago

The trunk build can now be installed and I've updated the version 4 build to use the new branch. Just waiting for the built files to propagate into the update site.

Provisionally all looks fine for version 4 now.