Open k9dog-gmail opened 1 year ago
same problem for me - can you please fix it - this addon is so great and works so perfect with adi bags!!!!
I don't currently have a classic era character, but I'll see what I can do. If nothing else, you should be able to use a previous version.
AFAIK, Blizzard changed the Lua API in 1.14.x (Era) to ... Shadowlands(?), introducing the infamous "Backdrop" errors to Era:
27x ...tter\Libraries/MC2UIElementsLib/MC2UIElementsLib.lua:165: attempt to call method 'SetBackdrop' (a nil value)
The good news is: The BCC version Outfitter-2.0.64.TBC seems to work fine for me.
I created a new character to test in Classic. There were issues with the some namespace changes (C_Container being a major one). I have a fix I'm testing and hopefully should be available soon.
Can you test out my draft release from my fork? https://github.com/GovtGeek/Outfitter/releases/tag/3.0.4.6
I'am afraid that something went wrong and you rereleased the assets of the (not working) version 3.0.4 from 25 january 2023.
Look:
5x Interface\AddOns\Outfitter\OutfitterInventory.lua:845: attempt to index global 'C_Container' (a nil value)
[string "@Interface\AddOns\Outfitter\OutfitterInventory.lua"]:845: in function Synchronize' [string "@Interface\AddOns\Outfitter\OutfitterInventory.lua"]:760: in function
GetInventoryCache'
[string "@Interface\AddOns\Outfitter\Outfitter-3.0.4.lua"]:4018: in function GetNewItemsOutfit' [string "@Interface\AddOns\Outfitter\OutfitterEquipment.lua"]:991: in function
RestoreSavedStack'
[string "@Interface\AddOns\Outfitter\OutfitterEquipment.lua"]:969: in function Initialize' [string "@Interface\AddOns\Outfitter\Outfitter-3.0.4.lua"]:4778: in function
Function'
[string "@Interface\AddOns\Outfitter\Libraries/MC2SchedulerLib/MC2SchedulerLib.lua"]:242: in function OnUpdate2' [string "@Interface\AddOns\Outfitter\Libraries/MC2SchedulerLib/MC2SchedulerLib.lua"]:178: in function
OnUpdate'
[string "@Interface\AddOns\Outfitter\Libraries/MC2SchedulerLib/MC2SchedulerLib.lua"]:20: in function <...fitter\Libraries/MC2SchedulerLib/MC2SchedulerLib.lua:20>
Was that on login or did you do something specific?
I am using the BugGrabber/Bugsack Addons, which intercept&show all the Lua errors. And this shows up right after login.
Please check the assets attached to your release, these dates seems wrong to me:
I have a new release package up. Looks like I didn't package up the branch like I thought.
I confirm: No Lua errors on login and switching gear while riding works fine. It seems that we have a winner :)
Now i get errors with ADI bags when i activate the latest Outfitter, now lua error with deactivated outfitter:
Message: Interface\AddOns\AdiBags\core\Utility.lua:465: attempt to call field 'GetContainerItemQuestInfo' (a nil value)
Time: Wed Apr 19 03:33:38 2023
Count: 74
Stack: Interface\AddOns\AdiBags\core\Utility.lua:465: attempt to call field 'GetContainerItemQuestInfo' (a nil value)
string "=[C]": in function GetContainerItemQuestInfo' [string "@Interface\AddOns\AdiBags\core\Utility.lua"]:465: in function
GetContainerItemQuestInfo'
[string "@Interface\AddOns\AdiBags\widgets\ItemButton.lua"]:333: in function UpdateIcon' [string "@Interface\AddOns\AdiBags\widgets\ItemButton.lua"]:344: in function
Update'
[string "@Interface\AddOns\AdiBags\widgets\ItemButton.lua"]:319: in function FullUpdate' [string "@Interface\AddOns\AdiBags\widgets\ItemButton.lua"]:276: in function <Interface\AddOns\AdiBags\widgets\ItemButton.lua:264> [string "=[C]"]: in function
Show'
[string "@Interface\AddOns\AdiBags\widgets\ContainerFrame.lua"]:1093: in function PrepareSections' [string "@Interface\AddOns\AdiBags\widgets\ContainerFrame.lua"]:1215: in function
FullUpdate'
[string "@Interface\AddOns\AdiBags\widgets\ContainerFrame.lua"]:643: in function <Interface\AddOns\AdiBags\widgets\ContainerFrame.lua:629>
[string "@Interface\AddOns\AdiBags\core\Utility.lua"]:106: in function <Interface\AddOns\AdiBags\core\Utility.lua:98> [string "@Interface\AddOns\AdiBags\widgets\LayeredRegion.lua"]:119: in function <Interface\AddOns\AdiBags\widgets\LayeredRegion.lua:108>
That looks to be an issue with AdiBags not fixing the GetContainerItemQuestInfo call to a C_Container.GetContainerItemQuestInfo call. The change I made took out a bunch of C_Container fixes for things Outfitter didn't use.
I took another look at the code. The current iteration of my fix ends up being global and affects other addons, instead of local to Outfitter as intended.
I'll work on trying to get it localized so it won't affect other addons.
I worked through the AdiBags call and realized it even has a comment where the error happens:
-- This function isn't present on classic-era in any form
This is why it's failing. I still needed to fix my scoping issue, but AdiBags still needs to do some checking that the function exists before trying to use it.
@DeTosc Can you try the newer prerelease? https://github.com/GovtGeek/Outfitter/releases/tag/3.0.4.6.2
@Dragotex I know AdiBags doesn't work with the fix I'm linking, but it should be better overall. To temporarily fix AdiBags, try adding this in Utility.lua at line 463:
_, _, _, toc = GetBuildInfo()
if toc == 11403 then return nil, nil, nil end
https://github.com/GovtGeek/Outfitter/releases/tag/3.0.4.6.2 seems to work fine for me.
@GovtGeek thx for your help - seems workaround does its job - no lua errors in the last 3 hours
@Dragotex I know AdiBags doesn't work with the fix I'm linking, but it should be better overall. To temporarily fix AdiBags, try adding this in Utility.lua at line 463:
_, _, _, toc = GetBuildInfo() if toc == 11403 then return nil, nil, nil end
Adding the line at 463 in Adibags solved the issue :)
@DeTosc I moved some stuff around under the covers in a new release. Can you try it out to make sure I didn't break something else? https://github.com/GovtGeek/Outfitter/releases/tag/3.0.4.6.4
@Dragotex @Shamatix Glad I could help. I posted the fix on the AdiBags issue too.
Hi, sorry for the late reply, well ... it seems that you released older, broken stuff from 25 january
Hi, sorry for the late reply, well ... it seems that you released older, broken stuff from 25 january
Can you let me know what errors you got? I'm going back and forth between some branches and want to make sure I see the same things you do.
Well, first of all, outfitter is not considering the settings. I turn off the minimap button, with this version the button appears and clicking on it shows this weird cross:
The Frame besides the char panel is empty:
And this is the lua error messages I got from BugSack:
2x Interface\AddOns\Outfitter\OutfitterInventory.lua:845: attempt to index global 'C_Container' (a nil value)
[string "@Interface\AddOns\Outfitter\OutfitterInventory.lua"]:845: in function Synchronize' [string "@Interface\AddOns\Outfitter\OutfitterInventory.lua"]:760: in function
GetInventoryCache'
[string "@Interface\AddOns\Outfitter\Outfitter-3.0.4.lua"]:4018: in function GetNewItemsOutfit' [string "@Interface\AddOns\Outfitter\OutfitterEquipment.lua"]:991: in function
RestoreSavedStack'
[string "@Interface\AddOns\Outfitter\OutfitterEquipment.lua"]:969: in function Initialize' [string "@Interface\AddOns\Outfitter\Outfitter-3.0.4.lua"]:4778: in function
Function'
[string "@Interface\AddOns\Outfitter\Libraries/MC2SchedulerLib/MC2SchedulerLib.lua"]:242: in function OnUpdate2' [string "@Interface\AddOns\Outfitter\Libraries/MC2SchedulerLib/MC2SchedulerLib.lua"]:178: in function
OnUpdate'
[string "@Interface\AddOns\Outfitter\Libraries/MC2SchedulerLib/MC2SchedulerLib.lua"]:20: in function <...fitter\Libraries/MC2SchedulerLib/MC2SchedulerLib.lua:20>
Locals: self =
Classic Era is 1.14.3. This addon claims to be Classic Era compatible. The errors seem to indicate otherwise. I know some errors might be expected due to people requesting Wrath, but would be nice to know status. I'll try downloading Wrath version and see if file lave just is wrongly indicating.