search

cengiz-pz / godot-android-notification-scheduler-plugin

Notification Scheduler Plugin allows scheduling of local notifications on the Android platform.
MIT License
20 stars 4 forks source link

Adjust Channel Importance #6

Closed zaddok closed 3 days ago

zaddok commented 2 months ago

Thank you for sharing this, much appreciated.

When my local notifications are sent, I am not seeing a popup slide in on to the screen in the same way I see it on iOS. I think I am trying to make the "Settings -> notifications -> app name -> Pop On Screen" set to on by default. (If this is possible) I am trying to work out why it is not on. It may be related to when a channel is created.

There appear to be multiple options, ie:

https://developer.android.com/reference/android/app/NotificationManager#IMPORTANCE_DEFAULT

And it seems like IMPORTANCE_HIGH might be needed in order to make a popup appear on screen. But the NotficationChannel Godot class does not appear to have a way to set channel importance, is that correct? How do we set channel importance? Will a patch to the android plugin be needed?

zaddok commented 2 months ago

I've done some testing, IMPORTANCE_HIGH does allow on screen notifications. Each of these settings have numbers in the documentation, ie:

IMPORTANCE_HIGH = 4, IMPORTANCE_DEFAULT = 3, IMPORTANCE_LOW = 2,

So perhaps we need to be able to pass in an int or an enum.

zaddok commented 2 months ago

Im trying to work out how to build the plugin from source by opening it with Android Studio but there are all sorts of build errors I don't know anything about. Im not sure how long it's going to take. :).

Is there any chance you could push out an update for us that allows changing the channel importance. In the mean time I'll keep googling weird grade errors. :)

Steps to build from scratch on Mac. Assumes you have already installed the 'brew' package manager, the 'git' package, and the java package

brew install gradle
git clone git@github.com:cengiz-pz/godot-android-notification-scheduler-plugin.git
cd godot-android-notification-scheduler-plugin
echo "sdk.dir=/Users/username/Library/Android/sdk" > local.properties
ksh gradle build
cengiz-pz commented 2 months ago

Hi @zaddok, this seems to be a good feature to add to the plugin. Thanks for bringing it up. I'll look into it when I get the chance.

cengiz-pz commented 2 months ago

Hi @zaddok, let me know if the new release resolves this issue.

https://github.com/cengiz-pz/godot-android-notification-scheduler-plugin/releases/tag/v2.1