Closed mstllc closed 4 years ago
I don't necessarily have an idea either, I don't have much experience with cmake I'm afraid. fwiw this element has only been tested / built on windows and linux, so I'm not too surprised that there would be a build issue on OSX. Please do let me know if you find a fix though :)
No problem, thanks for following up! I have setup Linux in a virtual machine and was able to get the plugin running there, so for now, I'll probably continue down that path. If I end up coming back around to trying to get it working on macOS I will definitely let you know and open a PR if I have a good solution.
Thanks again, closing for now.
@mstllc good to hear :) Few things worth noting about the plugin:
audio capture relies on API that was merged then removed in cef, so for now we're stuck with an older version of CEF. https://bitbucket.org/chromiumembedded/cef/issues/2755/reimplement-audio-mirroring-for for context.
The element needs a GMainContext
to be running, this piece of code: https://github.com/centricular/gstcefsrc/blob/master/gstcefsrc.cc#L231-L239 ideally needs replacing, but CEF's API is a bit obscure and that was the simple solution
You may want to check out wpesrc
: https://gstreamer.freedesktop.org/documentation/wpe/index.html?gi-language=c , I don't think it has audio support yet however (https://github.com/Igalia/WPEBackend-fdo/pull/100 is related)
I have a WIP branch for audio support in gstwpe: https://gitlab.freedesktop.org/philn/gst-plugins-bad/-/tree/wpe-audio which depends on https://bugs.webkit.org/show_bug.cgi?id=207634 as well.
I just got a need to get cefsrc working under MacOS as I need accelerated ProRes encoder.
@mstllc did you mange to get MacOS working in the end?
Will see if I get to root cause of why project doesn't build under MacOS and if I can fix it
Seems like this is the answer https://bitbucket.org/chromiumembedded/cef/src/25c75c5fc4fc7d7fbdebdf20ca56ab3162eab570/tests/cefsimple/CMakeLists.txt.in#lines-89 Need to configure Cmake to work for macos. I guess will give it a shot and see how far I get
Realized that it might take too long for me to finish. Someone who has used cmake to build MacOS libraries would be a better fit to do this. (My attempt https://github.com/centricular/gstcefsrc/compare/master...reinismu:gstcefsrc:macos-support)
We could reopen this issue?
Hey @reinismu , sorry I'm at the gst hackfest, just noticed your messages. I'm OK with reopening the issue if there is a WIP branch to iterate from, your comment here will be a bit buried though, might be best to open a whole new one?
Hey there! Thanks for working on this, it looks like it could be a promising solution to the current problem I'm working on solving :)
Eventually, I'll be running this on a Linux server, but during testing I'm using macOS. When I run the build steps in the README, things go pretty well until the very end. The
cmake
command downloads cef and extracts it, and everything seems good with thecmake
command. When I run themake
command, the build process get's through 97% of the process, I see it builds the targetlibcef_dll_wrapper
successfully, but then I see these error lines at the end of the build process:Any idea if there are some different steps I need to take to get this up and running on macOS? I don't have a lot of experience with cef, so maybe it's something I need to do differently in regard to building that?
Any help or pointers would be greatly appreciated! Thanks again!