search

centricular / gstcefsrc

A simple gstreamer wrapper around Chromium Embedded Framework
84 stars 45 forks source link

Hyperscale #15

Closed djelyash closed 3 years ago

MathieuDuponchelle commented 3 years ago

Hey, I can't merge such a PR, many unrelated commits, no descriptions of what they're doing, and probably quite a few hacks for your own use case afaict :)

I'm going to close this, but please reopen separate PRs for things you think are worth upstreaming, with detailed descriptions ideally :)

djelyash commented 3 years ago

hi sorry this pull request open by mistake, but for your question i need to support remote navigation, so I'm adding support for gstreamer navigation events and send them to CEF as key press, i'm also need to support some feedback from the html page so I'm adding listener to javascript callback all in my fork right now. Thanks for creating this.

MathieuDuponchelle commented 3 years ago

@djelyash ah I understand, nice to see you noticed my comment on your fork :) If you have a standalone commit for navigation events that you want to open a PR for, I'll be happy to review / test it :)