search

centricular / gstcefsrc

A simple gstreamer wrapper around Chromium Embedded Framework
84 stars 45 forks source link

Use F32LE format for audio #18

Closed reinismu closed 3 years ago

reinismu commented 3 years ago

From what I know big-endian is rare format. When I was writing custom recorder for cef my output was in F32LE

MathieuDuponchelle commented 3 years ago

we can't just pick the endianness though, we simply have to mirror whatever CEF is giving us, and I'm decently sure I had picked BE for a reason, though the audio capture API has changed since then

reinismu commented 3 years ago

I currently run my version compiled using F32LE. I'm surprised that it works both ways tho

MathieuDuponchelle commented 3 years ago

yes, I also tried and was surprised, I don't have a good explanation why either works rn :)

MathieuDuponchelle commented 3 years ago

Closing for now, if I ever find time to understand what exactly is at play here I will comment :)

MathieuDuponchelle commented 3 years ago

@reinismu I made sense of it, there was an inconsistency in the code, we ended up pushing F32LE caps anyway, that's why the two other places where F32BE was used didn't make a difference, apart from also making no sense :D