search

centricular / gstcefsrc

A simple gstreamer wrapper around Chromium Embedded Framework
84 stars 45 forks source link

Add enable-begin-frame-scheduling flag #19

Closed reinismu closed 3 years ago

reinismu commented 3 years ago

This seems to help when running headless https://bitbucket.org/chromiumembedded/cef/issues/1368

Tested and it worked fine with it

MathieuDuponchelle commented 3 years ago

Interesting, the issue is a bit involved, but it looks like there's a correlation between usage of this flag and CPU usage, do you think a property would make sense?

reinismu commented 3 years ago

I don't think it would give any harm. It is used in CasparCG as well https://github.com/CasparCG/server/blob/7ac31ee94f810a41c931e2000f11c874b7da7930/src/modules/html/html.cpp#L189

MathieuDuponchelle commented 3 years ago

tnx, let me test locally :)

MathieuDuponchelle commented 3 years ago

OK, fwiw on my machine I don't see a clear difference when using https://www.testufo.com/ as the source, but it also has no negative impact on the CPU

MathieuDuponchelle commented 3 years ago

ooc, does this improve something on your end?

reinismu commented 3 years ago

No clear difference. Could be it doesn't give so much performance. Tho it is mentioned in many places https://github.com/cztomczak/cefpython/issues/240 But ye up to you to put it in or not

MathieuDuponchelle commented 3 years ago

well I took it, if everything breaks it will be your fault of course