search

centricular / gstcefsrc

A simple gstreamer wrapper around Chromium Embedded Framework
84 stars 45 forks source link

use plugin location to find gstcefsubprocess bin #31

Closed ghostnumber7 closed 3 years ago

ghostnumber7 commented 3 years ago

Related to talks on #28 and #30 Removes target_compile_definitions for gstcefsubprocess and locales paths in favor of inferring path based on plugin location.

MathieuDuponchelle commented 3 years ago

Thanks, I trust you tested the uninstalled case?

MathieuDuponchelle commented 3 years ago

also please fix up your commits :)

ghostnumber7 commented 3 years ago

@MathieuDuponchelle never trust strangers online XD. I did test both installed and uninstalled, but I might have tested something wrong, so I would be more at ease if you give it a spin before merge, just in case. I tried to clean the commit log with force push, have no idea how to fixup xD

MathieuDuponchelle commented 3 years ago

@ghostnumber7 OK, let me test then

MathieuDuponchelle commented 3 years ago

Works just fine, just a couple comments (git commit -a --amend once you've fixed them), good work :)

ghostnumber7 commented 3 years ago

Works just fine, just a couple comments (git commit -a --amend once you've fixed them), good work :)

tried, failed, forced again xD

MathieuDuponchelle commented 3 years ago

tried, failed, forced again xD

yes, you need to force push after you've modified the history of a branch, not familiar with git? :)

ghostnumber7 commented 3 years ago

tried, failed, forced again xD

yes, you need to force push after you've modified the history of a branch, not familiar with git? :)

Use it daily but don't care much for all the "test" and "fix" commits on the log xD

MathieuDuponchelle commented 3 years ago

I see, for personal projects I don't care either, but it's always nicer to read a history that doesn't exclusively consist of variations on "WIP" :)

ghostnumber7 commented 3 years ago

I see, for personal projects I don't care either, but it's always nicer to read a history that doesn't exclusively consist of variations on "WIP" :)

For sure. I'll always comply with owner preferences, no worries :P

MathieuDuponchelle commented 3 years ago

Thanks again

reinismu commented 3 years ago

Nice :) So now when copying stuff around we wont get GPU error?

MathieuDuponchelle commented 3 years ago

presumably, I've only ever used the plugin from its build directory tbh :)

ghostnumber7 commented 3 years ago

Nice :) So now when copying stuff around we wont get GPU error?

Yes, it should allow for you to move it anywhere as long as the lib is in the same folder as the bin