Closed ghostnumber7 closed 3 years ago
Thanks, I trust you tested the uninstalled case?
also please fix up your commits :)
@MathieuDuponchelle never trust strangers online XD. I did test both installed and uninstalled, but I might have tested something wrong, so I would be more at ease if you give it a spin before merge, just in case. I tried to clean the commit log with force push, have no idea how to fixup xD
@ghostnumber7 OK, let me test then
Works just fine, just a couple comments (git commit -a --amend
once you've fixed them), good work :)
Works just fine, just a couple comments (
git commit -a --amend
once you've fixed them), good work :)
tried, failed, forced again xD
tried, failed, forced again xD
yes, you need to force push after you've modified the history of a branch, not familiar with git? :)
tried, failed, forced again xD
yes, you need to force push after you've modified the history of a branch, not familiar with git? :)
Use it daily but don't care much for all the "test" and "fix" commits on the log xD
I see, for personal projects I don't care either, but it's always nicer to read a history that doesn't exclusively consist of variations on "WIP" :)
I see, for personal projects I don't care either, but it's always nicer to read a history that doesn't exclusively consist of variations on "WIP" :)
For sure. I'll always comply with owner preferences, no worries :P
Thanks again
Nice :) So now when copying stuff around we wont get GPU error?
presumably, I've only ever used the plugin from its build directory tbh :)
Nice :) So now when copying stuff around we wont get GPU error?
Yes, it should allow for you to move it anywhere as long as the lib is in the same folder as the bin
Related to talks on #28 and #30 Removes
target_compile_definitions
forgstcefsubprocess
andlocales
paths in favor of inferring path based on plugin location.