search

centricular / gstcefsrc

A simple gstreamer wrapper around Chromium Embedded Framework
84 stars 45 forks source link

Generic chrome parameters passing #35

Closed amotzte closed 2 years ago

amotzte commented 2 years ago

Add a new prop called chromeExtraFlags

A comma delimiter flags to be passed into chrome (Example: show-fps-counter,remote-debugging-port=9222)

Example

 gst-launch-1.0  cefsrc url="https://soundcloud.com/platform/sama" chrome-extra-flags=remote-debugging-port=9222  ! ...
 gst-launch-1.0  cefsrc url="https://soundcloud.com/platform/sama" chrome-extra-flags=show-fps-counter  ! ...
 gst-launch-1.0  cefsrc url="https://soundcloud.com/platform/sama" chrome-extra-flags=show-fps-counter,remote-debugging-port=9222  ! ...

This eliminate the need for code change every time someone wants to expose a new flag to chrome (Chrome has more than 100 flags)

amotzte commented 2 years ago

CC @MathieuDuponchelle

MathieuDuponchelle commented 2 years ago

lgtm otherwise, I'll definitely get this in once nitpicks are addressed (you'll want to fixup your commits into a single one)

MathieuDuponchelle commented 2 years ago

ping @amotzte :)

amotzte commented 2 years ago

ping @amotzte :)

Will fix, in the next couple of days.

MathieuDuponchelle commented 2 years ago

I made a few amends locally and pushed to master, thanks again :)