search

centricular / gstcefsrc

A simple gstreamer wrapper around Chromium Embedded Framework
83 stars 45 forks source link

cmake: Allow user-supplied CEF_VERSION override #51

Closed philn closed 1 year ago

philn commented 1 year ago

if not provided with -DCEF_VERSION=... fallback to hardcoded version number.

philn commented 1 year ago

The context of this PR is to allow custom CEF builds, that could be done with https://github.com/philn/cef-build-box for instance. The Spotify CEF builds (obviously) don't ship with H.264 codec support, so in some cases like this a custom build is required.

MathieuDuponchelle commented 1 year ago

heh, that seems useful thanks. For the record I think you could already use a custom local build with CEF_ROOT, but the ability to fetch a custom build from the net is obviously nice to have :)

reinismu commented 1 year ago

@philn ohh you went thought with setting up CEF builder as well :D I did it too https://github.com/reinismu/cefbuild

Maybe it is worth linking this in README? So next one doesn't have to manually set it up

philn commented 1 year ago

Yeah, it was quite a pain in the butt :( +1 to mention both our cef build container projects in README :)

MathieuDuponchelle commented 1 year ago

go for it :)