search

centricular / gstcefsrc

A simple gstreamer wrapper around Chromium Embedded Framework
86 stars 45 forks source link

cefsrc: Add cef_cache_location property #57

Closed reinismu closed 1 year ago

reinismu commented 1 year ago

When recording same website multiple times it helps to have most resources cached :)

Now looking at CefSettings I wish we could just pass json and fill it up. Could solve all similar PRs down the line.

MathieuDuponchelle commented 1 year ago

Yes, mapping all fields as properties is a little bit obnoxious. The only alternative I can think of would be to register a new boxed type around CefSettings, and then registering serialization / deserialization functions with gst_value_register for command line usage. That's a bit complex though :)

MathieuDuponchelle commented 1 year ago

I'm happy with the patch as it is anyway, merging, but @reinismu if you feel like playing around with the idea you can find the entry point for an example here: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/gst-editing-services/ges/ges.c#L166