search

centricular / gstcefsrc

A simple gstreamer wrapper around Chromium Embedded Framework
83 stars 45 forks source link

Allow commas in chrome flags #63

Closed frostbyte73 closed 2 months ago

frostbyte73 commented 1 year ago

Before: gstcefsrc.SetProperty("chrome-extra-flags", "disable-features=site-per-process,TranslateUI,BlinkGenPropertyTrees")

Adding switch with value disable-features=site-per-process
Adding flag TranslateUI
Adding flag BlinkGenPropertyTrees

After: gstcefsrc.SetProperty("chrome-extra-flags", "disable-features=site-per-process|TranslateUI|BlinkGenPropertyTrees")

Adding switch with value disable-features=site-per-process,TranslateUI,BlinkGenPropertyTrees
MathieuDuponchelle commented 1 year ago

Ah, I see, that's a bit of a bummer :( Are there any guarantees that | will indeed not occur in values ?

frostbyte73 commented 1 year ago

Ah, I see, that's a bit of a bummer :( Are there any guarantees that | will indeed not occur in values ?

No guarantees, but generally the list flags are comma separated. I considered trying to escape the commas instead but my c++ is pretty rusty

MathieuDuponchelle commented 1 year ago

I see. Would turning the property into an array of strings instead solve the issue?