fix builds on macos arm64 and pay attention to USE_SANDBOX flag

centricular / gstcefsrc

A simple gstreamer wrapper around Chromium Embedded Framework

83 stars 45 forks source link

fix builds on macos arm64 and pay attention to USE_SANDBOX flag #67

Closed pyldin601 closed 1 year ago

pyldin601 commented 1 year ago

Fixes https://github.com/centricular/gstcefsrc/issues/66

reinismu commented 1 year ago

And it actually works? From what I recall it couldn't launch cef properly. Started to look into it a while ago https://github.com/centricular/gstcefsrc/compare/master...reinismu:gstcefsrc:macos-support Tho didn't get far

pyldin601 commented 1 year ago

@reinismu At least, it started compiling, but gstcefsubprocess runs into segmentation fault...

MathieuDuponchelle commented 1 year ago

Hah, thanks for the patch I suppose, I will merge it because you say it makes things compile when they didn't before, but I don't really have a clue what we're doing here :) Good luck to you on making this actually work beyond compiling though, I hope you figure it out :)