search

certat / do-portal

This project is in maintenance mode and will only receive bug fixes, but no new features. A new version of this software is being developed.
5 stars 5 forks source link

If abuse-c is set manually it should be set as main abuse-c and indicated #54

Closed certrik closed 5 years ago

certrik commented 5 years ago

If the Abuse-C contact is set manually it has priority over the Abuse-C automatic from RipeDB. This should also be indicated in the frontend somehow.

MarkHofstetter commented 5 years ago
  1. what does priority mean? the return result when the notification settings are queried?
  2. there may be more than one abusec added manually
certrik commented 5 years ago
  1. Yes the return result when the settings are queried.
  2. True. This should not be possible. It should be prevented to add another manual abuse-c.
certrik commented 5 years ago

all different now ...

  1. All manual abuse-c should be returned if queried (They have priority over the automatic abuse-c(s))
  2. It is okay to have more than one manual (or also automatic) abuse-c

If an automatic abuse-c is deactivated by defining at least one manual abuse-c than the automatic abuse-c should be greyed out and the comment field should state "DEACTIVATED manually"

certrik commented 5 years ago

Cannot test beacuse adding ripe handle throws 502 error. error_ripe

MarkHofstetter commented 5 years ago

this happens when the handle is already used, proper error handling has to be implemented

please test with a different handle

get list via database:

select ripe_org_hdl from fody.organisation_automatic;

ripe_org_hdl

ORG-AGNS1-RIPE ORG-AA1-RIPE ORG-AWK1-RIPE ORG-AAPA1-RIPE ORG-BISG1-RIPE ORG-BD1-RIPE ORG-CAGF1-RIPE ORG-CIP1-RIPE ORG-CA1-RIPE ORG-CA2-RIPE ORG-DO1-RIPE ORG-DA2-RIPE ORG-TAG1-RIPE ORG-ETSG1-RIPE ORG-CFCG1-RIPE ORG-FA1-RIPE ORG-GSA1-RIPE ORG-IMH1-RIPE ORG-IKA1-RIPE ORG-IEG1-RIPE ORG-II1-RIPE ORG-IISW1-RIPE ORG-IEWA1-RIPE ORG-IA1-RIPE ORG-JDIJ1-RIPE ORG-KA1-RIPE ORG-WKVK1-RIPE ORG-KE1-RIPE ORG-SK1-RIPE ORG-IKTC1-RIPE ORG-LSG1-RIPE ORG-LID1-RIPE ORG-LKEU1-RIPE ORG-MDSW1-RIPE ORG-MII1-RIPE ORG-FRJ1-RIPE ORG-MTSG1-RIPE ORG-MMC1-RIPE ORG-MAA1-RIPE

certrik commented 5 years ago

Nope. Doesnt work.

MarkHofstetter commented 5 years ago

please some details which handle does not work on which organisation etc

MarkHofstetter commented 5 years ago

just checked it locally (can't connect to webserver via vpn) and everything works as expected

certrik commented 5 years ago

The list above doesnt work and also others that are not on that list for example ORG-BTG4-RIPE . I am testing with Organization Full Name 20 . Multiple Austrian ASNs .

certrik commented 5 years ago

Tried to reuse an already existing ripe handle and the correct error "This RIPE handle already exists. " is thrown. So it seems like a different problem.

MarkHofstetter commented 5 years ago

I am able to reproduce the error now, have to check/fix on stage beacuse cannot reproduce on my devel machine

MarkHofstetter commented 5 years ago

works now, a db migration was missing

certrik commented 5 years ago

Trying with ORG-CNH1-RIPE but no abuse-c is shown.

MarkHofstetter commented 5 years ago

please try again, detached session problems (hopefuly) resolved

certrik commented 5 years ago

Abuse-C is not shown. ORG-ESTG1-RIPE

MarkHofstetter commented 5 years ago

i just added ORG-ESTG1-RIPE to Parent Organization: Organization Abbreviation 4 Name: Organization Full Name 20 Abbreviation: Organization Abbreviation 20

https://#!/organizations/20

and it worked w/o problems

certrik commented 5 years ago

Well adding the ripe-handle works. That is true but I don't see the abuse-c contact.

MarkHofstetter commented 5 years ago

abusec is returned but not displayed

{"abusec": ["f"], "asns": [{"asn": "21039", "notification_setting": {}}], "cidrs": [{"cidr": "2a0a:1e00::/29", "notification_setting": {}}, {"cidr": "193.186.224.0/20", "notification_setting": {}}, {"cidr": "193.186.240.0/21", "notification_setting": {}}, {"cidr": "193.186.216.0/21", "notification_setting": {}}], "name": ""}

davewood commented 5 years ago

ripe abusecs used to be delivered as

{"abusecs": ...}

now they come as

{"abusec": ...}

davewood commented 5 years ago

since the value of abusec[s] is an array, the old form (abusecs) makes more sense to me.

MarkHofstetter commented 5 years ago

it's abusec (again)

davewood commented 5 years ago

works on stg again now.

certrik commented 5 years ago

Can confirm that abuse-c is shown again. Thanks. But still there is no indication that it is not used anymore if a manual abuse-c is provided.

If an automatic abuse-c is deactivated by defining at least one manual abuse-c than the automatic abuse-c should be greyed out and the comment field should state "DEACTIVATED manually"

MarkHofstetter commented 5 years ago

what do you mean by

But still there is no indication that it is not used anymore if a manual abuse-c is provided.

the web does not use it anyway, and the API call either gets the ripe abusec OR the manual abusec if present

It may be useful to have some clear documentation that for OUR automatic services the manual abusec has precedence

certrik commented 5 years ago

It should be clearly visible by the user of the frontend that the manual abuse-c is prefered. Just usability improvement.

davewood commented 5 years ago

Is it sufficient if "Abuse-C Automatic" email addresses are greyed out? (see stageing env for an example)

certrik commented 5 years ago

Well it would be better if it is also stated in the comment. Is it somehow possible to implement that or would it break a lot. I am just looking for a good way that the user who possibly doesnt know anything sees at first sight what is going on.

davewood commented 5 years ago

what change to the current state would you like to see in the comment?

certrik commented 5 years ago

If possible change the comment to "DEACTIVATED manually" .

davewood commented 5 years ago

fixed: https://github.com/certat/customer-portal/commit/807f382321f9b96a5bfd220bef0ec6e0d919b96e

cant properly test until i can add RIPE contacts

certrik commented 5 years ago

It seems not to work. Just tested on staging. Organization 20. Abuse-C automatic email address is shown grey. It stays grey even if manual abuse-c is delted. Comment section of abuse-c automatic is not altered in any way.

davewood commented 5 years ago

it doesn now after git pull

certrik commented 5 years ago

Thanks