search

ceumicrodata / mETL

mito ETL tool
161 stars 41 forks source link

Target csv on Windows adds extra line #28

Open charleslukowski opened 9 years ago

charleslukowski commented 9 years ago

Using Windows and Python 2.7 I get an extra line between all rows of my output.

screenclip 15

coolestpizzadude commented 9 years ago

I had the same issue (on windows , python 2.7.10). It can be resolved by modifying 2 lines in the the file: metl/source/base.py in OpenResource Line 46 reads: file_pointer = codecs.open( resource, mode, encoding ) I changed it into: file_pointer = codecs.open( resource, mode+'b', encoding )

Line 49 reads: file_pointer = codecs.open( resource, mode ) I changed it into: file_pointer = codecs.open( resource, mode+'b' )

This means the mode parameter only gets changed if the resource is a file (and not an URL). Adding the 'b' seems necessary on windows (and it doesn't do anything on Linux, so it should be fine). Maybe there is a more elegant solution, but this seems to work fine for me.

cheers! Coolestpizzadude