search

cggh / scikit-allel

A Python package for exploring and analysing genetic variation data
MIT License
287 stars 49 forks source link

Adressing is_accessible problem in roh_mhmm, issue #296 #327

Closed hardingnj closed 4 years ago

hardingnj commented 4 years ago

Supersedes #300

Thanks for your work on this @olavurmortensen. Apologies for the delay in review.

pep8speaks commented 4 years ago

Hello @hardingnj! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-07-08 09:26:51 UTC
alimanfoo commented 4 years ago

Also @hardingnj would be great if you could add an entry in the release notes (docs/release.rst) crediting yourself and @olavurmortensen.

hardingnj commented 4 years ago

All should be done! Always happy to relearn how to git rebase properly :)

olavurmortensen commented 4 years ago

Cool, nice to see this done :)

alimanfoo commented 4 years ago

Thanks @olavurmortensen and @hardingnj :-)