cgq-qgc / HydroSensorReader

This project provides tools to read files from probes, sensors, or anything used in hydrogeology.
MIT License
8 stars 2 forks source link

PR: Refactoring of solinst readers #42

Closed jnsebgosselin closed 4 years ago

jnsebgosselin commented 4 years ago

The goal is to remove an extra layer of code that was present for the Solinst readers by adding a new function read_solinst_file that returns a Solinst reader object appropriate to the given file type.

This is the strategy that is used by many packages, such as Pandas, so I guess this is not going to be too much confusing.

This should make the code easier to understand and make the maintenance and development of the Solinst readers easier by making the inheritance tree a little bit cleaner and easier to follow.

pep8speaks commented 4 years ago

Hello @jnsebgosselin! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 454:1: W391 blank line at end of file

Comment last updated at 2019-12-19 00:48:53 UTC