search

cgq-qgc / HydroSensorReader

This project provides tools to read files from probes, sensors, or anything used in hydrogeology.
MIT License
8 stars 2 forks source link

PR: Fix test for get_data_at_time #63

Closed jnsebgosselin closed 3 years ago

jnsebgosselin commented 3 years ago

We were passing a date instead of a datetime object to the TimeSeriesRecords.get_data_at_time method.

pep8speaks commented 3 years ago

Hello @jnsebgosselin! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 31:80: E501 line too long (81 > 79 characters)

codecov[bot] commented 3 years ago

Codecov Report

Merging #63 (e9da120) into master (15855c4) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   51.74%   51.74%           
=======================================
  Files          21       21           
  Lines        1834     1834           
=======================================
  Hits          949      949           
  Misses        885      885

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15855c4...e9da120. Read the comment docs.

jnsebgosselin commented 3 years ago

Somehow, comparing date and datetime in newer version of pandas doesn't work anymore.