search

cgrima / docker_i-librarian

Dockerfile and instructions for I, Librarian
36 stars 10 forks source link

Update the Docker Image #9

Closed nicolasshu closed 2 years ago

nicolasshu commented 3 years ago

Hi! Could I make a request to update the version from 5.8.0 to 5.9.2?

Thank you so much!

cgrima commented 2 years ago

Sorry for being late at pushing the last updates. It should be done now on both Github and Dockerhub.

nicolasshu commented 2 years ago

Nah, you're perfect! Thank you!

nicolasshu commented 2 years ago

It looks like the upgrade has a mismatch on the PDF viewer. When I look at a locally installed I, Librarian, I can use their PDF viewer as this: locally_installed

But when I use the Docker one, it looks like this: docker_installed

Do you think this is because of a lib package?

cgrima commented 2 years ago

I also use the 5.9.2 Docker image since yesterday, but I did not encounter this issue. Could you check in the administrator/Software Details if every dependencies have been installed properly?

Here is my example: image

nicolasshu commented 2 years ago

So I was looking into it further. When I went to inspect the site loading, as it loaded each page, it failed to run the imagecreatefromjpeg() used in PHP 7.4.21. 

Call to undefined function Librarian\Media\imagecreatefromjpeg().

As I looked further, it looked as one needed to now configure the gd extension on PHP to use the tags --with-freetype and --with-jpeg. So I went into the container using docker exec and ran the commands below based on this

docker-php-ext-configure gd --with-freetype=/usr/include/ --with-jpeg=/usr/include
docker-php-ext-install gd

So I think that you might need to add 

RUN docker-php-ext-configure gd --with-freetype=/usr/include/ --with-jpeg=/usr/include

I'll create a pull request and please double check me

nicolasshu commented 2 years ago

It looks like it works now

solved

nicolasshu commented 2 years ago

Sorry, I only now just saw your previous comment. I spun up a new container just to see what would happen if I started fresh, and this is the dependencies page:

probs2

However, when I went to see if it could load a PDF using its viewer, I saw this: probs

where if I went to inspect it, I would see this problem: probs3