search

cgrindel / rules_swift_package_manager

Collection of utilities and Bazel rules to aid in the development and maintenance of Swift repositories using Bazel.
Apache License 2.0
68 stars 22 forks source link

Propagates preprocessor SWIFT_PACKAGE #1093

Closed leohidalgo closed 1 month ago

leohidalgo commented 1 month ago

I have a target that when it depends on an SPM package, the preprocessor definition SWIFT_PACKAGE becomes true.

I think that the expected behavior should have a value of false.

brentleyjones commented 1 month ago

True, it should only be set for the target itself, instead of propagated. Basically local_defines instead of defines.

cgrindel commented 1 month ago

@leohidalgo Can you check if #1094 fixes your issue?

leohidalgo commented 1 month ago

@leohidalgo Can you check if #1094 fixes your issue?

It works, thanks.