Closed stephanecopin closed 3 months ago
@stephanecopin I ran bazel run //:tidy
on this branch and updated it. This got the new integration test running. However, there appears to be some absolute paths from your machine somewhere in the code.
Ah my bad, that was leftover code from when I was investigating the @import
issue 😅 I've removed it, should be all good now
It looks like you do not have any test targets. Can you add one that launches the iOS app or at least a build_test that ensures that the iOS app builds?
@cgrindel ah right, I've added a build_test
as the example will not launch without a valid Google Maps API key.
It looks like you forgot to add load("@bazel_skylib//rules:build_test.bzl", "build_test")
to the file with the build_test
.
Ah my bad! That's what you get for doing that late 😅 I've updated & verified it passes locally, so hopefully should be all good now
file --brief
, useotool -l
to see if the library isdynamic
, and if not default tostatic
.@import GoogleMaps;
in the headers for the frameworks otherwise. FYI, the error is:I quickly looked into it but couldn't find an easy fix, so patching seemed like the easiest solution.
cc @cgrindel - would love feedback on this! I didn't do any processing on the
otool -l
command as I didn't think it to be necessary.Closes #1084