cgrindel / rules_swift_package_manager

Collection of utilities and Bazel rules to aid in the development and maintenance of Swift repositories using Bazel.
Apache License 2.0
75 stars 26 forks source link

fix: improve xcframework archive file link type detection #1102

Closed stephanecopin closed 3 months ago

stephanecopin commented 3 months ago

cc @cgrindel - would love feedback on this! I didn't do any processing on the otool -l command as I didn't think it to be necessary.

Closes #1084

cgrindel commented 3 months ago

@stephanecopin I ran bazel run //:tidy on this branch and updated it. This got the new integration test running. However, there appears to be some absolute paths from your machine somewhere in the code.

stephanecopin commented 3 months ago

Ah my bad, that was leftover code from when I was investigating the @import issue 😅 I've removed it, should be all good now

cgrindel commented 3 months ago

It looks like you do not have any test targets. Can you add one that launches the iOS app or at least a build_test that ensures that the iOS app builds?

stephanecopin commented 3 months ago

@cgrindel ah right, I've added a build_test as the example will not launch without a valid Google Maps API key.

cgrindel commented 3 months ago

It looks like you forgot to add load("@bazel_skylib//rules:build_test.bzl", "build_test") to the file with the build_test.

stephanecopin commented 3 months ago

Ah my bad! That's what you get for doing that late 😅 I've updated & verified it passes locally, so hopefully should be all good now