search

cgrindel / rules_swift_package_manager

Collection of utilities and Bazel rules to aid in the development and maintenance of Swift repositories using Bazel.
Apache License 2.0
75 stars 26 forks source link

fix: fix `byName` resolution #1117

Closed brentleyjones closed 3 months ago

brentleyjones commented 3 months ago

In the case of accessibilitysnapshot, it depends on SnapshotTesting by name. SnapshotTesting has an identity of swift-snapshot-testing (based on the git url, but it could be different for mirrors/forks), but the name is snapshottesting.

brentleyjones commented 3 months ago

That's exactly what this change is doing, matching on package name. It was previously trying to match on package identity, which is based on the URL of the package.

cgrindel commented 3 months ago

That's exactly what this change is doing, matching on package name. It was previously trying to match on package identity, which is based on the URL of the package.

Fair enough. Thanks for the clarification.

brentleyjones commented 3 months ago

@cgrindel after this is merged can we get a 0.34.1 release?