search

cgross / angular-busy

Show busy/loading indicators on any element during $http requests (or any promise).
http://cgross.github.io/angular-busy/demo
MIT License
1.44k stars 256 forks source link

support Q Promise #24

Closed debuggingfuture closed 10 years ago

debuggingfuture commented 10 years ago

Q is quite a popular library on promise. I find it easier to code angular with promises wrapped into Q. Angular-busy support .then in general, however seems if that is Q promise it is not supported.

Now I would need to use a workaround to wrap Q back into $q promise

cgross commented 10 years ago

I love Q and wish that Angular would allow you to plug in full Q the same way you can plug in full JQuery. Unfortunately the primary benefit of $q is that its integrated with Angular scopes. In order to support Q, I have to wrap a Q promise in a $q promise so that the appropriate scope will be refreshed. But at least thats now transparent to you.

debuggingfuture commented 10 years ago

Big thanks work like a charm! Btw you committed to gh page not master? Le 11 mai 2014 01:54, "Chris Gross" notifications@github.com a écrit :

I love Q and wish that Angular would allow you to plug in full Q the same way you can plug in full JQuery. Unfortunately the primary benefit of $q is that its integrated with Angular scopes. In order to support Q, I have to wrap a Q promise in a $q promise so that the appropriate scope will be refreshed. But at least thats now transparent to you.

— Reply to this email directly or view it on GitHubhttps://github.com/cgross/angular-busy/issues/24#issuecomment-42749186 .

cgross commented 10 years ago

Doh! Merged to master. Thanks for mentioning that. I didn't realize I was on gh-pages when I did all the work!