search

cgross / angular-busy

Show busy/loading indicators on any element during $http requests (or any promise).
http://cgross.github.io/angular-busy/demo
MIT License
1.44k stars 256 forks source link

angular-busy vs angular 1.3.0 #31

Closed char0n closed 9 years ago

char0n commented 10 years ago

Hello,

I was trying to update my project to angular 1.3.0 and test if it works as before, but I found out that there is some problem with angular-busy vs angular 1.3.0. angular-busy is exhibiting very strange behavior, appears whenever it wants.

The POC can be made very easily. Just change version of angular 1.2.x to 1.3.0-build.2810+sha.adcc5a0 and angular-busy stops working as expected.

aaronchar commented 10 years ago

I see the exact same thing

seems to work fine with 1.3.0-build.2674+sha.3f540e3

char0n commented 10 years ago

Hi,

I was able to fix it by providing configuration for $animateProvider and constraing the ngAnimate to .repeated-item css class.

.config(['$animateProvider', function configureAnimateProvider($animateProvider) { $animateProvider.classNameFilter(/repeated-item/); }])

aaronchar commented 10 years ago

My issue on this was due to Angular not removing the ng-animate class from an element when it was stopped to quickly.

char0n commented 10 years ago

Angular version: 1.3.0-build.3038+sha.01d81cd angular-busy versin: 4.1.0

When you downgrade angular to: 1.3.0-build.2991+sha.9025113 everything works as expected.

This is what console shows:

TypeError: Cannot read property '$$pending' of undefined at Promise.then (http://localhost:8080/vendor/angular/angular.js:11723:15) at d (http://localhost:8080/vendor/angular-busy/dist/angular-busy.min.js:1:940) at http://localhost:8080/vendor/angular-busy/dist/angular-busy.min.js:1:349 at Object.forEach (http://localhost:8080/vendor/angular/angular.js:328:18) at Object.c.reset (http://localhost:8080/vendor/angular-busy/dist/angular-busy.min.js:1:294) at http://localhost:8080/vendor/angular-busy/dist/angular-busy.min.js:1:2252 at Object.$watchCollectionAction (http://localhost:8080/vendor/angular/angular.js:12660:13) at Object.ng.config.$provide.decorator.$delegate.proto.$watch.applyFunction as fn at Scope.$get.Scope.$digest (http://localhost:8080/vendor/angular/angular.js:12789:29) at Scope.ng.config.$provide.decorator.$delegate.proto.$digest (:844:31) angular.js:10318 (anonymous function) angular.js:10318 $get angular.js:7575 $get.Scope.$digest angular.js:12808 ng.config.$provide.decorator.$delegate.proto.$digest VM9409:844 $get.Scope.$apply angular.js:13054 ng.config.$provide.decorator.$delegate.proto.$apply VM9409:855 (anonymous function) angular.js:1504 invoke angular.js:4082 doBootstrap angular.js:1502 bootstrap angular.js:1516 angularInit angular.js:1428 (anonymous function) angular.js:23484 jQuery.Callbacks.fire jquery.js:3073 jQuery.Callbacks.self.fireWith jquery.js:3185 jQuery.extend.ready jquery.js:3391 completed

cgross commented 9 years ago

Fixed in v4.1.1