search

cgross / angular-busy

Show busy/loading indicators on any element during $http requests (or any promise).
http://cgross.github.io/angular-busy/demo
MIT License
1.44k stars 257 forks source link

Position:relative #42

Open katmai7 opened 10 years ago

katmai7 commented 10 years ago

After when promise resolved , position:relative doesn't remove from element.

cgross commented 10 years ago

Is that an issue for you? Angular-busy intentionally adds that class so it can layout the overlay correctly. Usually adding position:relative to an element is inconsequential. Does it affect something in your case?

katmai7 commented 10 years ago

Yes, it's problem. It is necessary to remove this rule, if the tag doesn't have this css property.

cgross commented 10 years ago

Could you help me understand why its a problem. I'm interested to know why its affecting you.

katmai7 commented 10 years ago

I create plunker http://plnkr.co/edit/dsXpPrQfHfTrgm9c91bJ?p=preview. So u can see how position:relative affect on block inside div.wrap. I don't want position div.pos relatively div.wrap.

cgross commented 10 years ago

Ah I see. You have some absolutely positioned content inside the div. If the position:relative is removed from the div after the promise is complete - does that really solve the problem? Would the text still be incorrect while the promise is running and the busy message is shown?

katmai7 commented 10 years ago

Yes, it's solve problem. The main idea, that plugin must return initial state of tag(like jquery plugin).

kencaron commented 8 years ago

I don't know of an easy solution for this. But this relative positioning is making this unable to apply to a table's tbody without losing styling. I have a table that you can delete rows from serverside, and I was hoping to use cg-busy on it.