Open stephanie-dm opened 9 years ago
cgross
commented
9 years ago I've tried but I can't reproduce this problem. With angular 1.2.26 and setting the promise to null or undefined - I cannot reproduce the error you're seeing.
Perhaps you can investigate more on your end or provide a reproducible example using plnkr or similar service.
stephanie-dm
commented
9 years ago I've investigated this problem a little further and I've come to a different conclusion: the problem I'm seeing occurs everywhere I use an Angular resource as a promise for cgBusy.
In my controller I have the following code:
$scope.dossiers = Dossier.query();
In my HTML, I do this:
<div cg-busy="[dossiers]">
This worked fine in angular-busy 4.1.0, but not anymore in 4.1.1 (then it causes the error "cgBusy expects a promise (or something that has a .promise or .$promise ")
But when I change the HTML to this:
<div cg-busy="[dossiers.$promise]">
Then the busy-indicator works again in version 4.1.1 and Angular 1.2.26
Sorry I didn't provide a Plunkr, but I'm afraid I don't have the time for it at the moment. I hope I gave you enough information.
henriquecholo
commented
9 years ago I have the same issue of stephanie-dm..... i'm using Angular 1.3.1 and and Angular-busy 4.1.1
Just one thing, to make it work i just used Angular 1.2.26 and Angular-busy 4.1.0... Changed on bower worked for now, but I'm still waiting for a fix.
mckinleymedia
commented
9 years ago I had the same issue. I solved it with a simple ng-init:
<div cg-busy="{promise:promise,message:message,templateUrl:'a-busy.html'}" ng-init="promise = $promise">
mckinleymedia
commented
9 years ago Update - when I do a subsequent full refresh of the page, the ng-init method fails. It worked for many conditions. To solve it, I had to hack the angular-busy.js "addPromiseLikeThing" function as follows: var addPromiseLikeThing = function(promise){ var then = tracker.getThen(promise);
if (!then) {
// throw new Error('cgBusy expects a promise (or something that has a .promise or .$promise');
}
if (then) {
if (tracker.promises.indexOf(promise) !== -1){
return;
}
tracker.promises.push(promise);
then(function(){
promise.$cgBusyFulfilled = true;
if (tracker.promises.indexOf(promise) === -1) {
return;
}
tracker.promises.splice(tracker.promises.indexOf(promise),1);
},function(){
promise.$cgBusyFulfilled = true;
if (tracker.promises.indexOf(promise) === -1) {
return;
}
tracker.promises.splice(tracker.promises.indexOf(promise),1);
});
}
};Removed the error and encased the promise-processor in an if statement.
stephanie-dm
commented
9 years ago I have upgraded to 4.1.3 and I can't reproduce this issue anymore.
The following code works again if "dossiers" is the result of a resource-call that returns an array:
<div cg-busy="[dossiers]">
After upgrading from angular-busy 4.1.0 to 4.1.1 (while still depending on angular 1.2.26), we get the following error on pages where angular-busy is used:
We didn't get this error with 4.1.0, so 4.1.1 doesn't seem backwards compatible to me :) I think we're getting this error because when we use cg-busy="myPromise", myPromise is often still
undefinedat page load (it only gets initialized when we click some button). But then again, this did work before the upgrade.