search

cgross / angular-busy

Show busy/loading indicators on any element during $http requests (or any promise).
http://cgross.github.io/angular-busy/demo
MIT License
1.44k stars 256 forks source link

fix bug in case object is not promise but have promise property #51

Closed ygalbel closed 9 years ago

ygalbel commented 9 years ago

Hi, I very love your code and use it in my production apps like https://github.com/backand/angularbknd. It's very powerful stuff because it don't load any image and work only with pure CSS.

I think you have a small bug in line 46, when parameters is not a promise, but have a property called $promise. I think is not right to check property name is '$promiseThing'.

Thanks again for your code. Ygal

cgross commented 9 years ago

Thanks!