Open ghernandez81 opened 9 years ago
Also, there is a tag missing for v4.1.4
, so you can't event set a branch/tag target in the interim.
Thats because there is no 4.1.4. The latest ver is 4.1.3.
Please, can you upgrade angular-busy in NPM ? (npm install angular-busy@4.1.3 doesn't exist)
+1
+1 Hi, I would also benefit from having it updated, let me give you my reason:
Support for Webpack + CommonJS Package Manager
I'm in the process of refactoring an app to support modern JS tooling like NPM, Webpack & ES6.
A small change is needed to support CommonJS:
/* commonjs package manager support (eg componentjs) */
if (typeof module !== "undefined" && typeof exports !== "undefined" && module.exports === exports){
module.exports = 'cgBusy';
}
I have done other PRs for some of my dependencies:
BTW @gabehayes you can use latest master commit with the following format in package.json:
"angular-busy": "git+https://github.com/cgross/angular-busy.git"
+1
but i think there should be module.exports = 'cgBusy'
instead of module.exports = 'angular-md5'
then it's compatibile with CommonJS and Angular style (and Webpack)
You're right, fixed! Any chance we could se an npm release soon @cgross ?
Would love to see this so I don't have to fork and maintain to use in my webpack-driven project
currently in npm it's 4.1.0