R Journal R1 - Githubissues

[x] C1-1: I feel this article is really informative to R users about how code style in R packages has evolved over time. In general the figures and writing were clear, easy to follow, and were able to articulate the rationale for why the exploration is important. The examples of the types of styles that the study authors are exploring are helpful to understand the differences.
[x] C1-2: The biggest question I had while reading this manuscript that I didn't find in the manuscript was an exploration of style within packages. Were there instances of cases that the style was not consistent within a package? Is this highly prevalent or not? I personally think it could be interesting to explore these within a package across the elements that you explored. For example, I'd hypothesize that function names and TRUE/FALSE usage are more likely to be consistent within a package, but the spaces, number of characters in a line, or other elements may have some variation. Many style guides also state that the most important element is to be consistent rather than picking a specific style, with, I think, the idea being that consistent code is easier to read than inconsistent code. Is this possible to explore?

[YEN] TBA - within packages variation. put entropy plot and naming convention within packages here

[x] C1-3: For figure 1, the term "_ratio" is after all of the facet labels and is not really needed here. The "fx_" at the beginning is also repeated. I'd recommend removing these and possibly adding more descriptive labels to help with the figure being self-contained.
[x] C1-4 The line length gif attached in the paper is difficult to interpret and the y-axis is labeled as proportion, however ranges outside of 0/1. Therefore it is unclear what the y-axis is representing here and appears to be different than figure 3 referenced as a snapshot of the gif.
[x] C1-5: Is it possible to detect or determine any shifts in the object oriented systems (ie. S3 vs S4)?
[x] C1-6: There seems to be a lot of "other" function names over time, particularly early in the time frame and highly prevalent in some of the categories identified. Are there examples of these styles? (715b1f5) Are there patterns within this other style to identify why the percentage is so large? (b85b2c8)
[x] C1-7: Finally, would it be possible to highlight in some way the style elements that are being explored in the current study. This can help show the differences more easily and be visually appealing.

chainsawriot / rstyle