search

chairemobilite / evolution

Online survey platform for travel survey
MIT License
4 stars 9 forks source link

Generator: Move checkConditional outside the Generator and tests the function. #771

Closed samuel-duhaime closed 2 weeks ago

samuel-duhaime commented 2 weeks ago

Pull request

Description

Move checkConditionals to evolution-common Add tests for checkConditionals Change checkConditionals to accept conditional like _activePersonId

BREAKING CHANGE: Survey using the Generator need to do 'yarn generateSurvey' again or change the import of the checkConditionals

samuel-duhaime commented 2 weeks ago

@tahini C'est prêt à être review maintenant, il y a des tests.

samuel-duhaime commented 2 weeks ago

@tahini Okay, I made all the corrections I was asked for. I think the test titles are more clear now.