search

chandra-mta / MTA

0 stars 0 forks source link

Acis_Focal_Scripts #4

Closed william-aaron-CFA closed 1 year ago

william-aaron-CFA commented 1 year ago

General issues:

  1. Conversion to Ska3/flight environment
  2. Inclusion of Unit tests
  3. Inclusion of lock files for race condition handling
  4. Should store processed data in astropy fits files.
  5. Change operation to pulling dumps files from arc5gl instead of requiring running on c3po-v to access /dsops/GOT
  6. Reduce/eliminated dependency on MTA common functions.

full_focal_plane_data.py:

  1. Unnecessary to store the backup of the full data list for previous years. Change to removing previous years backup if the new year of focal data is being filled out.
  2. Change add_leading_zero separate function to string native method zfill().
william-aaron-CFA commented 1 year ago

General issue:

  1. Remove zspace paradigm wherever possible.
william-aaron-CFA commented 1 year ago

deprecation warning in full_focal_plane_data.py. /proj/sot/ska3/flight/lib/python3.10/site-packages/numexpr/expressions.py:21: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead. _np_version_forbids_neg_powint = LooseVersion(numpy.version) >= LooseVersion('1.12.0b1')

william-aaron-CFA commented 1 year ago

PR #5 Addressed parts of these issues. Remaining issues.

General Issues:

  1. Inclusion of unit tests for create_focal_temperature_plots.py, create_week_long_plot.py, create_html_pages.py
  2. Convert to Astropy data fits files
  3. Operate with arc5gl instead of pulling dumps from /dsops.
  4. reduce dependence on mta_common_functions.
william-aaron-CFA commented 1 year ago

Closing this issue to more clearly compartmentalized the issues with the ACIS focal scripts.