search

charmbracelet / vhs-action

Keep your GIFs up to date with VHS + GitHub actions 📽️
MIT License
164 stars 5 forks source link

Lipgloss styling not applied in the generated gif #91

Closed Morphclue closed 1 year ago

Morphclue commented 1 year ago

Description

In my Bubble Tea application, I have implemented a user interface using the lipgloss package for styling. The application runs as expected when executed locally, with the desired lipgloss styles being applied. However, when running the application through the charmbracelet/vhs-action GitHub Action to generate a GIF, the lipgloss styles are not visible in the resulting .gif.

I don't have the expertise in Go / Linux to be precise / pinpoint the problem, but my suggestions would be that:

I have tried to add xterm-256color to the workflow, but it still did not display the correct colors. Also ignore the installation at the beginning. I have tried to incorporate golang-cache into my action, and thanks to the new version of Lipgloss, something has been downloaded again during the new generation of a tape.

Versions

References

bashbunni commented 1 year ago

When termenv tries to query the terminal used in CI, it might lock up the CI process. This is the case with Circle CI, for example. In this case we know the environment this is being run in, so we can unset the env variable we're setting in termenv to prevent the colours from showing.

Ayman is going to work on this :)

aymanbagabas commented 1 year ago

@Morphclue could you try using the ci-colors branch in your workflow?

The config should be like this

      - uses: charmbracelet/vhs-action@ci-colors
        with:
          path: 'demo.tape'
        env:
          TERM: xterm-256color
Morphclue commented 1 year ago

Thank you very much for the help. The problem seems to be fixed. In any case, the colors are now displayed correctly.

I don't know if this is related to the change in the ci-colors-branch, but the "load times" until the program is executed after a go run . seem to be longer than before. But this could also be due to my project. I would leave it to you to decide if this is relevant to this issue or if you want to close this issue.