Feature request: make has_expected_title? retry to match title till timeout

cheezy / page-object

Gem to implement PageObject pattern in watir-webdriver and selenium-webdriver

MIT License

653 stars 220 forks source link

Feature request: make has_expected_title? retry to match title till timeout #190

Closed smartkiwi closed 10 years ago

smartkiwi commented 11 years ago

I'm building tests using page-object for the web site that uses AngularJS and there are cases when finial title is shown with some delay after page load.

Here is link to the code in my fork: https://github.com/smartkiwi/page-object/commit/a269d2a566155e3ff742afac9936a0ee1a51cba3#diff-2f097973797173d9cea14f27dd9c78e4

It is no a proper pull request for now - I'm not yet proficient in ruby - so I'm still learning ruby till I'll be able to write rspec tests for my change.

cheezy commented 10 years ago

I hate to change the behavior of an existing method. Would you mind updating your patch to make it a new method named wait_for_expected_title ?

smartkiwi commented 10 years ago

Good point Please see my this pull request https://github.com/cheezy/page-object/pull/194

cheezy commented 10 years ago

Merged lastest pull request