search

cheezy / page-object

Gem to implement PageObject pattern in watir-webdriver and selenium-webdriver
MIT License
653 stars 220 forks source link

refactoring of page_populator #448

Closed vveliev closed 7 years ago

vveliev commented 7 years ago

for some reason text_field population was failing, so I have decided to refactor popular

vveliev commented 7 years ago

not sure how to fix specs, as element class does not match actual.

cheezy commented 7 years ago

@vveliev I'm not ready to accept this PR at this time. All of the unit tests around this are failing. I'd be happy to pair with you to address them. Since it is not really adding any new functionality, I'm not going to include it in the 2.2.4 release.

cheezy commented 7 years ago

We cannot apply this PR because it will break population for custom Widgets.