search

chetachiezikeuzor / Highlightr-Plugin

A minimal and aesthetically pleasing highlighting menu that makes color-coded highlighting much easier 🎨.
Mozilla Public License 2.0
585 stars 32 forks source link

highlightr broken in 0.15.9 even after latest update #47

Closed KraXen72 closed 10 months ago

KraXen72 commented 1 year ago

image doesen't create the right click menu for "highlight" at all

chetachiezikeuzor commented 1 year ago

Geez, alright I understand the issue now. I'm using a function in the new update that's only available in Obsidian 0.16.0 Insider build. Sorry for this, I'll fix this as soon as possible. Thank you for your patience!

archaeaMby commented 1 year ago

KraXen72, I encountered the same problem. Thank you for putting your issue here! Chetachi, Thank you for developing such a great plugin!

tankilo commented 1 year ago

Expect this problem to be fixed.

cremepvff commented 1 year ago

highlighter is still not working, unsure if this has been fixed yet

dlion commented 1 year ago

Yep, it is still broken. @chetachiezikeuzor Do you have any ETA for this?

UPDATE: uh, I saw that with the last commit, the problem had been fixed: https://github.com/chetachiezikeuzor/Highlightr-Plugin/commit/61341a464456cdc868ffa1480341136025ec8389, but I guess we still don't have a plugin update. Patching the local version it works again

yarub123 commented 5 months ago

@dlion Hey dude from 2 years ago. Hope you're well.

Just curious how would I go about locally patching it? I'm browsing the files of that commit that you mentioned but don't see main.js (probably since it's on "releases.") Is there a way to go about doing it?

dlion commented 5 months ago

Hey @yarub123 , I think the issue was fixed a long time ago. BTW if you want to have a local patch you can edit the local version of the plugin. For example, in this case, you can just find your Highlightr plugin folder, find the file src/ui/highlighterMenu.ts, and edit it. Re-open Obsidian and done. Be aware that every time you update the plugin your changes will be overridden.

yarub123 commented 5 months ago

@dlion Good man. Appreciate the response. I figured it out yesterday. Something was wrong with my obsidian, a simple restart fixed it. I forgot to update my comment in here, but it's still good to know. Thanks again brotha.