chief-nerd / Tabbie2

The Tabbie2 project main repo
https://www.tabbie.org
19 stars 10 forks source link

Change example CSV files to use comma-seperators rather than semicolons #71

Closed philipbelesky closed 5 years ago

philipbelesky commented 6 years ago

This better matches the expectation that when the example files are opened with Excel/etc the column headers will span across cells properly rather than being 'smushed' together. While semicolon separators are supported the default import option and provided files are CSVs so this seems like the more user-friendly option.

I've tested both the download and import on my local copy and it appears to work as intended. Not entirely sure what SampledataController does; I assume it generates the csv files under /assets/.

rscoates commented 6 years ago

This looks fine to me.

chief-nerd commented 5 years ago

Looks like a duplicate ... will close.