search

chief-nerd / Tabbie2

The Tabbie2 project main repo
https://www.tabbie.org
19 stars 10 forks source link

Improve motion balance diagram readability #72

Closed philipbelesky closed 6 years ago

philipbelesky commented 6 years ago

The first commit adds small unobtrusive labels in the corners of the motion balance diagram to more easily identify which team the polygon is 'pointing' to.

The second commit re-orients the diagram (and labels) to match the layout of a ballot and the spatial layout of a debate which I think is the more intuitive way of reading the diagram. That said this is a break to how users are used to the diagram working (but the labels should help clarify this). If this change is undesirable feel free to cherry pick just the first commit.

This image shows the effects of commit 1 on the left and commit 1+2 on the right. While the polygon can overlap with the labels in a manner that doesn't look super great motion balance shouldn't be that bad outside of the odd out-round so this should be relatively rare.

This has been tested on a local copy.

rscoates commented 6 years ago

Looks good to me - I had tried to do this before, but failed.

philipbelesky commented 6 years ago

@rscoates ah, great to hear its something you were looking for anyway. Is there anything preventing this and my other PRs from being merged?

rscoates commented 6 years ago

Not from my end, but I haven't spoken to JR about these yet. I'll grab him today.