search

chlorinejs / lein-bower

Leiningen plugin for managing Bower dependencies in Clojure projects
66 stars 13 forks source link

incompatibility with lein npm #15

Open cedrictools opened 9 years ago

cedrictools commented 9 years ago

Given this options in project.clj


:node-dependencies [["adm-zip" "latest"]
                          ["nedb" "latest"]]
     :npm-root "webkit"
     :bower {:directory "webkit/bower"}
     :bower-dependencies [[react "0.12.2"]
                                          [d3 "latest"] ]

Running lein bower install, will fail because bower.json is expected in project root but created inside the "webkit" folder due to the :npm-root option. ( https://github.com/RyanMcG/lein-npm/blob/master/src/leiningen/npm.clj#L13 )

There must be nicer ways to solve this, however dissoc :npm-root ( https://github.com/cedrictools/lein-bower/commit/47491ac514a560654680fd3af174cf79bd1472d3 ) did the trick. ( 2 lein profiles also does).

jvandyke commented 9 years ago

@cedrictools can you create a pull request for this so it's easy to merge in?

@myguidingstar Can you take a look at this and patch it in please?