search

chlorinejs / lein-bower

Leiningen plugin for managing Bower dependencies in Clojure projects
66 stars 13 forks source link

Regression due to lein-npm; also auto-installing Bower for convenience #19

Closed radhikalism closed 7 years ago

radhikalism commented 9 years ago

Changes in lein-npm's API removed with-json-file which lein-bower depended on. I've fixed this by duplicating a snippet of code (with-ephemeral-file) from lein-npm rather than having them expose their file-handling code as it's sufficiently trivial. Dependency on lein-npm is bumped to 0.6.1.

Also, I've made lein-bower respect lein-npm's :root parameter as a local installation could be nested in another directory.

While I was at it, I added a default pathway for lein-bower to automatically install a local Bower (via lein-npm) on first run, so less pre-configuration is required to get started. As a consequence, a couple more configuration options were added (:install-missing-bower and :location). The invocation flow is a little more forgiving and informative now.

hackeryarn commented 7 years ago

Thanks for the commit! This is a perfect solution to a few issues.