search

chlorinejs / lein-bower

Leiningen plugin for managing Bower dependencies in Clojure projects
66 stars 13 forks source link

Add configurable config filenames under :bower #2

Closed radhikalism closed 10 years ago

radhikalism commented 10 years ago

Following discussion on #1, this is a new PR as that was closed and won't auto-update with additional commits.

Setting config filenames is now implemented without dynamic vars. (I think this style is unusually verbose, so I'm not sure it's a good idea to pass project around everywhere, but that seems to be how lein-npm expects it.)

Thanks.

myguidingstar-zz commented 10 years ago

Well done! In the future you should commit in smaller pieces because big commits make it hard to merge/resolve conflicts in SCMs. Clojure use immutable data structures so it's fine to pass things around everywhere. It's even much better to write unit tests (of course for bigger projects, not lein-bower ^^) Cheers!