search

chlorinejs / lein-bower

Leiningen plugin for managing Bower dependencies in Clojure projects
66 stars 13 forks source link

Bump lein-npm dependency for transitives handling #5

Closed radhikalism closed 10 years ago

radhikalism commented 10 years ago

Prior to lein-npm 0.3.2, only installed JARs were searched for transitive project.clj dependency settings. Leiningen "checkouts", however, were overlooked. This meant that when a checkout project's npm dependencies were updated, the downstream project would not see it until it was installed (which defeats the purpose of lein checkouts).

This affects bower dependencies too, as it relies on lein-npm to resolve transitives.

This should be fixed in lein-npm 0.3.2 with bodil/lein-npm#10. Could you bump the lein-npm dependency to it?

Thanks

myguidingstar-zz commented 10 years ago

Thanks for your help. There are lots of changes in lein-npm 0.4.0 and lein-bower should follow its convention so expect some extra work

myguidingstar-zz commented 10 years ago

I've just tried to upgrade lein-npm itself in a project of mine and it threw an "clojure.lang.PersistentVector cannot be cast to clojure.lang.Named" when lein-npm version >= 0.3.2 Haven't investigated it yet. Do you have the same problem? Or did I miss something about API changes?

radhikalism commented 10 years ago

That's new to me. Maybe raise an issue at lein-npm with steps to reproduce?

myguidingstar-zz commented 10 years ago

Wow, it turns out that when trying vinyasa, I've added this to leiningen's profiles.clj :dependencies key:

[leiningen #=(leiningen.core.main/leiningen-version)]

and it caused the problem above

myguidingstar-zz commented 10 years ago

Updated. Thanks @arbscht