search

chlorinejs / lein-bower

Leiningen plugin for managing Bower dependencies in Clojure projects
66 stars 13 forks source link

It's not obvious that :directory is required #8

Closed arohner closed 10 years ago

arohner commented 10 years ago

I installed lein-bower 0.4.0, and ran lein bower install with :bower-dependencies, but with no :bower

$ lein bower install

/usr/local/lib/node_modules/bower-canary/node_modules/tmp/lib/tmp.js:260
  throw err;
        ^
TypeError: Arguments to path.join must be strings
    at path.js:360:15
    at Array.filter (native)
    at Object.exports.join (path.js:358:36)
    at Project._readInstalled (/usr/local/lib/node_modules/bower-canary/lib/core/Project.js:551:26)
    at Project._analyse (/usr/local/lib/node_modules/bower-canary/lib/core/Project.js:428:14)
    at Project.install (/usr/local/lib/node_modules/bower-canary/lib/core/Project.js:46:17)
    at install (/usr/local/lib/node_modules/bower-canary/lib/commands/install.js:20:13)
    at Function.install.line (/usr/local/lib/node_modules/bower-canary/lib/commands/install.js:35:12)
    at Object.<anonymous> (/usr/local/lib/node_modules/bower-canary/bin/bower:87:27)
    at Module._compile (module.js:456:26)

Adding :bower {:directory "resources/public/js/lib"} fixed it.

myguidingstar-zz commented 10 years ago

Thanks. There should be a default value for that. What do you think is better: bower's convention bower_components or Clojure project structure resources/public/vendor? Code to be updated: https://github.com/chlorinejs/lein-bower/blob/master/src/leiningen/bower.clj#L16