chocolatey / home

The place to start for issues with areas of Chocolatey that are infrastructure related, or really any issues could be started here. There is also choco for the CLI client, Chocolatey GUI for the GUI.
Apache License 2.0
29 stars 10 forks source link

Package reported as passed even though it failed to install #12

Open gep13 opened 3 years ago

gep13 commented 3 years ago

elgato-game-capture 3.70.51.3051 was reported to have passed verification testing even though the log shows that it failed to install.

Verifier log: https://gist.github.com/choco-bot/658bc4865e9540b35f61d77ff43c5f36

The failure to install is what I now expect to happen, as I have discovered that I forgot to upload a file to my repo (the certificated to be installed), so it failed to be included in version 3.70.51.3051 of the package, and therefore it fails unless the certificate was previously installed. I have created a new version with fix notation that includes the certificate.

The failure happened during a Start-ChocolateyProcessAsAdmin command, perhaps did it not catch it because of something relating to chocolatey/choco#1016?

┆Issue is synchronized with this Gitlab issue by Unito

TheCakeIsNaOH commented 3 years ago

There are also some other packages where this is happening: subtitleedit 3.6.0 - gist bakkesmod - frst_gist, second_gist invantive-authenticator - gist

TheCakeIsNaOH commented 3 years ago

There are a lot more, all within the past three months:

gom-player v2.3.63.5327 - Passed - https://gist.github.com/f80a4f53b58007e6cc84b340317d0739 Vivaldi v3.7.2218.49 - Passed - https://gist.github.com/5e5fda093986692d72ed04b012e28c51 vivaldi.install v3.8.2238.3-snapshot - Passed - https://gist.github.com/5ad6e2dace99fe4685544fbd2d245ee5 ricardopignone-sqltools v1.0.0 - Passed - https://gist.github.com/8b2f6dd5068bd3db8f477d930a8b5738 FreeDownloadManager v6.0 - Passed - https://gist.github.com/4b867550f10e42d908a82940af757978 firefox-beta v88.0.2-beta - Passed - https://gist.github.com/285914bc97e4379ea3b0ec5e2fd197eb onenote-learningtools v2.0.1.0 - Passed - https://gist.github.com/f401423c8134ae3e84c769228b270f15 onenote-learningtools v2.0.1.0 - Passed - https://gist.github.com/ae5a12875e9a9b0ce88efc9a645e93eb logtalk v3.45.0 - Passed - https://gist.github.com/b53f13c7573035dc47f53d5d1a304a4d nodejs v14.16.0 - Passed - https://gist.github.com/456e37703137d17ff39a527062d4e98f josm v17580.0 - Passed - https://gist.github.com/db13e99c8e094b011ab8cd4597b08130 touchportal v2.3.004 - Passed - https://gist.github.com/2b1cceff567eb82bfabbc6d29c5c9104 lsnes v2.0.24 - Passed - https://gist.github.com/007279083f547fa93f48ef82b6428634 potplayer v21.03.18 - Passed - https://gist.github.com/82d810cd5365fa5122d70eaeb98c7162 ditto v3.24.191.0-beta - Passed - https://gist.github.com/24675a615e750c368a8c90d7df381cfa ditto.install v3.24.187.0-beta - Passed - https://gist.github.com/6cef59ea706d7c9cdbfb7dbdc9bc4e5f meshroom v2021.1.0 - Passed - https://gist.github.com/f111ec00726c916a80cce9a7e9e1831c retroarch-uwp v1.9.0 - Passed - https://gist.github.com/8f472e4d869782124f7acc6622ee8743 twitch-uwp v0.0.7779.0 - Passed - https://gist.github.com/bbdb972b663dfbc12f98bb02c0510cab electron-cash.portable v4.2.4 - Passed - https://gist.github.com/4203aebe0f849df5796d799654683405 cmake v3.20.0-rc5 - Passed - https://gist.github.com/34b4c3aeb5cd9dd05a526000af9cf8ab vivaldi.portable v3.7.2218.45 - Passed - https://gist.github.com/85243824305448dd403d28313ab67a10 Vivaldi v3.7.2218.45 - Passed - https://gist.github.com/923a378c5025465a7074b1185bb367e6 vivaldi.portable v3.7.2218.32-snapshot - Passed - https://gist.github.com/339ae5419172a3902c8e57b0689849e2 vivaldi.install v3.7.2218.25-snapshot - Passed - https://gist.github.com/1eb5fb4f2bc454e87de3704dabc31eb9 dvc v2.0.5 - Passed - https://gist.github.com/b51c1c718fcfb4b76f07fd56ddbd662e grammarly-edge v1.0.0 - Passed - https://gist.github.com/e5100c8186da409b008c234dc6be2a15 todolist v8.0.19 - Passed - https://gist.github.com/d54637c1753275368305c2e93e4dfed4 powerautomatedesktop v2.5.39 - Passed - https://gist.github.com/26f1f7e8bfef9dc04f1563668b79b921 kdeconnect-kde v1.4.513 - Passed - https://gist.github.com/a7339cec6b1b1aef7b7b9b2de23e7eda advanced-codecs v14.7.5 - Passed - https://gist.github.com/6b1c17fb3b5cafc22a3e39a3f24c3e49 openmodelica v1.16.5 - Passed - https://gist.github.com/8d86e5387544eefd1dfeb8b272c1e4ec sheepit-client v6.21055.0 - Passed - https://gist.github.com/4989439604d61b5e8d48b04eb936707c eset-endpoint-antivirus v0.3 - Passed - https://gist.github.com/fbf0dfd056e994c4240ba4b93ddbb4d9 cherrytree v0.99.31 - Passed - https://gist.github.com/c9de86f0218c80cea90771dcb16583a8 netch v1.7.6 - Passed - https://gist.github.com/8240bd602146dcaf7e06db797165d55b pslab-desktop v2.6.0 - Passed - https://gist.github.com/4e1d7ada8768cca386ab03511481d85f OctopusTools v7.4.3115 - Passed - https://gist.github.com/328b45018e14b3039a666c211b7af223 nextdns v2.0.1 - Passed - https://gist.github.com/e9e3d94fcac1378f565323dc0c4b3289 Octave v6.1.0 - Passed - https://gist.github.com/64169f0d86cbab2f54e326b635ffc86f powerautomatedesktop v2.3.2121 - Passed - https://gist.github.com/b755145d772b3de6d0da119f6c1e5e11 powerautomatedesktop v2.3.2121 - Passed - https://gist.github.com/b93d2819c2c13ed9720f05e110424859 dotnet-runtime v6.0.0-preview12110212 - Passed - https://gist.github.com/bc7ffd0f6a0a04ccf10b6c895d7dd4a6 dotnet-aspnetruntime v6.0.0-preview1211036 - Passed - https://gist.github.com/0e4d9aa8bffdfc6ef44728762edbd355 ditto v3.24.182.0-beta - Passed - https://gist.github.com/ef87b62ab50cf2cceb547eda6cfd2ef0 advanced-codecs v14.7.0 - Passed - https://gist.github.com/a0d684118f7c7917d37c0d35669b505f winsetupfromusb v1.9.0.0 - Passed - https://gist.github.com/b5e1e204ca50eac3d5f25cbc467519ea powerautomatedesktop v2.3.2121 - Passed - https://gist.github.com/56b4d60a8c5d33179f752e705718e35b 360ts v10.8.0.1262 - Passed - https://gist.github.com/715c8a17e56adb33791ff77748a15810 mssqlserver-compact4.0 v4.0.8876.1 - Passed - https://gist.github.com/065ac023a3b756b9f871202fe3f420c2 packetbeat v7.11.0 - Passed - https://gist.github.com/05284521abf44223ecaa91266618aca4 winlogbeat v7.11.0 - Passed - https://gist.github.com/843184e976b01a6b7656aef0b891ef5b filebeat v7.11.0 - Passed - https://gist.github.com/d8b9c2655a7fa3f1e42644ff286e8750 metricbeat.install v7.11.0-beta - Passed - https://gist.github.com/be5f0fc9523d0e07e52007bf31ab0152 powerautomatedesktop v2.3.2121 - Passed - https://gist.github.com/c91d9be6441f26817b915b812d2dec09 kdenlive v20.12.2 - Passed - https://gist.github.com/8dcf14010813f545105e11f3637c352f reWASD v562.3544 - Passed - https://gist.github.com/37519ffbc874bfb82fe28ebc6a3185bd ditto.install v3.24.179.0-beta - Passed - https://gist.github.com/2b7ab7288a3c476239b467cc1331032c spacedesk-client v0.9.82 - Passed - https://gist.github.com/fcbe1d00ade39427f9946283b57e67ae vivaldi.portable v3.6.2165.36 - Passed - https://gist.github.com/aa8eac26cbe81f7d677a4ce2abe84b2b Vivaldi v3.6.2165.36 - Passed - https://gist.github.com/4b587adc3f31fdf805adeb85ce29a4c4 trillian v6.4.0.5 - Passed - https://gist.github.com/a37e0f97d7e219540248cd53a19665c5 rdmfree v2020.3.28.0 - Passed - https://gist.github.com/d63b394870cd0db6fb04e9116528b836 allway-sync v20.2.1 - Passed - https://gist.github.com/e56f3db41720b0552c9a61d6e7a46a92 hybrid v2021.01.31.1 - Passed - https://gist.github.com/7a1d61fe9c53bdd8a0b76a511d74822b wechat v3.1.0 - Passed - https://gist.github.com/83f7c13732a2ccd061087a5414b11f8b octave.install v6.1.0 - Passed - https://gist.github.com/4d1285e3ca778498356ef77c0384296d microsoft-edge-insider-dev v89.0.774.8 - Passed - https://gist.github.com/0ebc8703bfd93f989b5aa9a0f8c208dd passcovery v1.0.0 - Passed - https://gist.github.com/d63b254cbca5bdf09bf59ae6314e866d mrviewer v5.7.2 - Passed - https://gist.github.com/207be69aa0258d48b174a2b5f9ef1599 onenote v16.0.13628.20274 - Passed - https://gist.github.com/641f1d4f72471a5da1b2e1c016eb2e8c chromium v90.0.4403.0-snapshots - Passed - https://gist.github.com/af8deb75c0a0d4161d3bba71d68ad407 freeoffice v2018.982 - Passed - https://gist.github.com/3e63a94fb10441b9aaaf5cd37f5ec90b bitwarden v1.24.4 - Passed - https://gist.github.com/31382ea73dfba66364abdf25413b4336 eset-internet-security v14.0.22.0 - Passed - https://gist.github.com/055430df5c2fe7015a8b4ccc5e8250cf OpenHardwareMonitor v0.9.6 - Passed - https://gist.github.com/1f454ed9dcde94afe6884f66953c836e wms v11.0.7 - Passed - https://gist.github.com/e74c521412f6a5a306ca167826371a03 vietex v4.0 - Passed - https://gist.github.com/bc2e80cba252e02b8781fc30e2d1d97c cs-script.core v1.4.5.0-NET5-RC5 - Passed - https://gist.github.com/16db6993be50190bc2fd9404e4006942 extraterm v0.57.1-pre - Passed - https://gist.github.com/4b0fd2837bf206bb8b27ea4399f3c9bd gimp-data-extras v2.0.4 - Passed - https://gist.github.com/b847e1e4be87203dd38e29ae783b5d9a lanconfig v10.42.28 - Passed - https://gist.github.com/7628745f9a6d9adad12c890745f3a101 trillian v6.4.0.3 - Passed - https://gist.github.com/46a9890317b84fea33da8ec1c5972ac7 eset.nod32 v1.2.0.0 - Passed - https://gist.github.com/cccba114fd7267712be339caaa63c77a googlechromebeta v88.0.4324.87-beta - Passed - https://gist.github.com/4d7af7403e7b9fa3f89612e19ae0b031 evga-flow-control v2.0.9 - Passed - https://gist.github.com/595d50f1c345bacf20e3b68baffa7959 orientdb v3.1.7 - Passed - https://gist.github.com/32ab445c7d9935628fce0c4d8c2649b6 rust-analyzer v2021.1.12-nightly - Passed - https://gist.github.com/9e2926df216f843af72c8ccddd888cc8 vietex v4.0 - Passed - https://gist.github.com/ee750ce35cce29528a681aa111a8d94e eset-nod32-antivirus v14.0.22.0 - Passed - https://gist.github.com/56fd0ba30c0dc6a77d4981605d1fd48d advanced-codecs v14.5.2 - Passed - https://gist.github.com/500d01b669740d316185e916f2a307ca brave-nightly v1.20.70-nightly - Passed - https://gist.github.com/704ecaa7f3b90e8d517902de3024b77d extraterm v0.57.0-pre - Passed - https://gist.github.com/f0e4887d35b1658f0848c38bb7d1cac9 lansweeper v8.1.120.4 - Passed - https://gist.github.com/734cf3d3833dc1f7449f666ae60316f5 Vivaldi v3.6.2160.3-snapshot - Passed - https://gist.github.com/56be40b498553a364e048854674c2848 onenote v16.0.13530.20316 - Passed - https://gist.github.com/420b032d2c2d792d40d995ca1e709b22 brave-nightly v1.20.62-nightly - Passed - https://gist.github.com/d9a562acccc8e965e225eb468027165e glooctl v1.6.1 - Passed - https://gist.github.com/5a057aea372f3eda9fd0cbc8eb67b9f5 fbxreview v1.4.1 - Passed - https://gist.github.com/c745389cb81919f13ce278cd9b1ed048 brave-nightly v1.20.60-nightly - Passed - https://gist.github.com/c25e54decfcbe2e81f004da0e3c7b3ef balabolka v2.15.0.767 - Passed - https://gist.github.com/24ac436e0d4782b44867c42fd87c50bb trillian v6.4.0.2 - Passed - https://gist.github.com/73d984a11ba3224ec15353cdf4c316b7 clockify v1.8.61 - Passed - https://gist.github.com/c5edef9f635436bfa681483569bf81b4 imagemagick.tool v6.9.11.55 - Passed - https://gist.github.com/15ccbc80e69830e696c7408637d02cb6 imagemagick.tool v7.0.10.55 - Passed - https://gist.github.com/1f55cc597e9eaa8b2d2ceb9b0255ba01 imagemagick.tool v7.0.10.54 - Passed - https://gist.github.com/d42fba64fd9de68e86bf597df171a69f vietex v4.0 - Passed - https://gist.github.com/0d635d4914a355bd4a8d2b3cddffecc7 marktext.portable v0.16.3 - Passed - https://gist.github.com/37f7e9c651783b8c0e70a222e86698be streamlink-twitch-gui v1.11.0 - Passed - https://gist.github.com/2823c6e7d44d0ee41723410113bfb86a advanced-codecs v14.4.7 - Passed - https://gist.github.com/0e5e1dfd7d9b4c82c94e0ab7fd343366 vietex v4.0 - Passed - https://gist.github.com/429d69cff4c3783fc350ae788b2b4bca imagemagick.tool v6.9.11.53 - Passed - https://gist.github.com/1de46b8e697580c34493ee61a6763a5b vietex v4.0 - Passed - https://gist.github.com/f8cc2e8527bb6f7b37700c531fd990b3 vietex v4.0 - Passed - https://gist.github.com/7eadd9fd5d83d59f521a2065c17356f9 vietex v4.0 - Passed - https://gist.github.com/e761a7e655c3df66f61df4699734b9b4 vietex v4.0 - Passed - https://gist.github.com/f088ac26429113fa038d824c880d1140 eclipse v4.18 - Passed - https://gist.github.com/b4ffb11d1af7da5a438f7b653e0c72e8 datadog-agent v7.25.0-rc-2 - Passed - https://gist.github.com/5dcb4db4e62ba9919077a507897064c2 citrix-receiver-ltsr v4.9.9002 - Passed - https://gist.github.com/8db6e972b7a070f97f0473fa111d1b5a phraseexpress.install v15.0.72 - Passed - https://gist.github.com/04191254b2ab84f8e01fc8dea822ed71 logreader v0.6.0 - Passed - https://gist.github.com/e252693209821445ad8c71b4d1c780fb azcopy10 v10.8.0 - Passed - https://gist.github.com/5adf9114470f2bbff22af4f8aa0be5dd xournalpp v1.0.19 - Passed - https://gist.github.com/e68f984c49c1ee5011493d1850680d6c Vivaldi v3.5.2131.8-snapshot - Passed - https://gist.github.com/a596a9929637ac0f1ab513cdbb259af2 minio-server v2020.12.10 - Passed - https://gist.github.com/523c541306dfcf08bf3cb53842081c41 minio-client v2020.12.10 - Passed - https://gist.github.com/53ca0ed8393b5145efce4289c617ee18 visualstudio2019testcontroller-preview v16.9.0.20000-preview1 - Passed - https://gist.github.com/b304d1a345604b091633d29bede483e3 dvc v1.11.3 - Passed - https://gist.github.com/5bd34eee5396003e4560c286cdd2487a vivaldi.install v3.5.2115.71-snapshot - Passed - https://gist.github.com/b8673b3672430fa70fb0c9bfda51a7f8 intellijidea-community v2020.3 - Passed - https://gist.github.com/22b2092913ad64d3f071d0838c001e5f voicemeeter-banana.portable v2.0.5.4 - Passed - https://gist.github.com/a952de5be96459197a9cfa484f8266c4 elgato-game-capture v3.70.51.3051 - Passed - https://gist.github.com/658bc4865e9540b35f61d77ff43c5f36 RubyMine v2020.3-EAP203-5981-120 - Passed - https://gist.github.com/19f3a77a453e0dead6ba2552930b71e8 vscode-insiders v1.52.0.20201203 - Passed - https://gist.github.com/03fe22a2d1facba6060839b27afc3909 brave v1.19.46-beta - Passed - https://gist.github.com/3fb6d4b330a3e9fe4e6de3042a288bd2


This is out of 7859 package results checked. So the verifier has a %1.71 false negative rate, averaged over the past four months or so.

brogers5 commented 2 years ago

+1 for xsplit-vcam v4.0.2205.3103 https://gist.github.com/6caf38d8d83437071d92d1e290866072

brogers5 commented 1 year ago

Just happened again with xsplit-vcam on v4.0.2206.2307 https://gist.github.com/choco-bot/96e888100c1ba817697465c17ceb2e11

AdmiringWorm commented 1 year ago

@brogers5 that is the uninstallation that fails. Uninstalls are currently allowed to fail on the Chocolatey Community Repository and won't fail the verifier. This is currently by design.

brogers5 commented 1 year ago

@AdmiringWorm In both of those cases, the install script failed as well. There was an OS requirement being enforced by chocolatey-os-dependency.extension that I was expecting Package Verifier to fail based on experience with other packages that implement it. The script does halt as expected, but the package was passed nonetheless.

brogers5 commented 1 year ago

gamesavemanager v3.1.512.0 https://gist.github.com/choco-bot/b398dfc5dd5b53fa67f4dc13b8573e9e

Corrupted ZIP archive, in this case.

AdmiringWorm commented 1 year ago

@brogers5 apologies, I did not see the failure in the install script. I only saw the one in the uninstall script. Ignore me.