chocolatey / home

The place to start for issues with areas of Chocolatey that are infrastructure related, or really any issues could be started here. There is also choco for the CLI client, Chocolatey GUI for the GUI.
Apache License 2.0
29 stars 10 forks source link

In the Community Repository, packages with icons do not show the icon in IconUrl #157

Open asheroto opened 2 years ago

asheroto commented 2 years ago

What You Are Seeing?

Any packages that use a staticaly.com or statically.io URL do not show the icon.

Most of the packages I maintain do not show the icon, here is a link to my profile with the packages: https://community.chocolatey.org/profiles/asheroto

I have not changed any packages in the past few weeks, so nothing has changed with the IconURL attribute in any of the packages. I just noticed the missing icons today, not sure when the problem but it must have been fairly recently, within the past few weeks.

I use cdn.staticaly.com on some and cdn.statically.io (their new domain) on others. Packages with either domain have the issue even though the image exists at the URL specified.

Occurs on any page where the icon should be displayed.

What is Expected?

The icon to appear instead of packageDefaultIcon.png.

How Did You Get This To Happen? (Steps to Reproduce)

Visited the community repository,.

System Details

Chrome, Firefox, Edge, all have the same issue, tried from two different computers.

Output Log

N/A

Reference screenshot

image

┆Issue is synchronized with this Gitlab issue by Unito

st3phhays commented 2 years ago

This could possibly be related to https://github.com/chocolatey/home/issues/42

asheroto commented 2 years ago

Yes, it appears so. The issue persists.

basvandenbrink commented 2 years ago

Same goes for the Betterbird package: https://community.chocolatey.org/packages/betterbird/91.10.0. That one is hosted on statically.io.

asheroto commented 2 years ago

Ping. This is an active issue that has been a problem for nearly a month now.... :-/

Reminder - nothing changed on our end. Something changed with Choco or Statically. 😊

pauby commented 2 years ago

@asheroto To manage expectations, this is a minor issue that doesn't affect the functionality or user experience of the site. It will be prioritised in line with that.

asheroto commented 1 year ago

Hello again,

Looks like this is still a problem with some packages.

The weird thing is that this is intermittent. I initially had it working in Edge, but not working in Chrome and Firefox, but I refreshed and now it's working in all of them.

Not sure if it's related to statically.io or not... JSONPrettyPrint works and FxSound doesn't, but both use cdn.statically.io. So it may be unrelated as per my original post.

https://community.chocolatey.org/profiles/asheroto


Chrome

image

image

for FxSound:

<iconUrl>https://cdn.statically.io/gh/asheroto/ChocolateyPackages/093acc183da465f30e835201c287cadb2d6da703/fxsound/icon.png</iconUrl>

Links to here: https://cdn.statically.io/gh/asheroto/ChocolateyPackages/093acc183da465f30e835201c287cadb2d6da703/fxsound/icon.png

image


Microsoft Edge

image

image

asheroto commented 1 year ago

Found something else. When it doesn't load, it shows a 404 in the network tab...

image

The Request URLs shown above are https://community.chocolatey.org/content/packageimages/fxsound.1.1.16.0.png https://community.chocolatey.org/content/packageimages/netscan.install.8.1.4.png https://community.chocolatey.org/content/packageimages/MessagesForWeb.0.0.7.3.png

Which don't work, but here's one that does...

https://community.chocolatey.org/content/packageimages/ventoy.1.0.91.png

If you go to the non-working ones and see a 404, that's what the browsers sees sometimes. Other times it will load the image.

If you append a string like ?v=2 it loads the image correctly. So this appears to be some caching issue on the server side? Even Ctrl+F5 doesn't refresh the image, even though that usually does a force refresh of the page.

https://community.chocolatey.org/content/packageimages/fxsound.1.1.16.0.png?v=2

Thought I could just clear the browser cache, but apparently the issue persists for some icons. Since it's not showing an old image, and actually giving us a 404, that tells me that the browser has the "latest" page but the server is sending a 404 instead of the image file.

Even with devtools up and Disable cache checked, it still shows a 404.

image

https://github.com/chocolatey/home/assets/49938263/c469202f-f014-4c8b-a790-1d9bf400ab70